Skip to content

Commit e6870fe

Browse files
authoredAug 15, 2023
fix: commonjs types, run tsc and lint to validate changes (#397)
* fix: types weren't working for commonjs. Run tsc and lint to validate changes * chore: needs to work on linux and BSD
1 parent 61d4eea commit e6870fe

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+1593
-44
lines changed
 

‎CONTRIBUTING.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22

33
* Before you open a ticket or send a pull request, [search](https://github.com/adaltas/node-csv/issues) for previous discussions about the same feature or issue. Add to the earlier ticket if you find one.
44

5-
* Before sending a pull request for a feature, be sure to have [tests](https://github.com/adaltas/node-csv/tree/master/test).
5+
* Before sending a pull request for a feature, be sure to have [tests](https://github.com/adaltas/node-csv/tree/master/packages/csv/test).
66

7-
* Use the same coding style as the rest of the [codebase](https://github.com/adaltas/node-csv/tree/master/src). If you’re writing a test and if you're just getting started with CoffeeScript, there’s a nice [style guide](https://github.com/polarmobile/coffeescript-style-guide).
7+
* Use the same coding style as the rest of the [codebase](https://github.com/adaltas/node-csv/tree/master/packages). If you’re writing a test and if you're just getting started with CoffeeScript, there’s a nice [style guide](https://github.com/polarmobile/coffeescript-style-guide).
88

99
* Documentation is published on [GitHub](https://github.com/adaltas/node-csv-docs) and you are invited to submit a pull request with your changes. For convenience, you can also browse the website and click on the Edit link present at the top of every page.

‎demo/eslint/.eslintrc.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ module.exports = {
1111
ecmaVersion: 'latest',
1212
},
1313
rules: {
14-
// 'import/no-unresolved': [2, { commonjs: false }],
14+
'import/no-unresolved': [2, { commonjs: false }],
15+
'no-console': 'off',
1516
},
1617
};

0 commit comments

Comments
 (0)
Please sign in to comment.