adaltas · Mar 15, 2024 · Mar 15, 2024 · Apr 24, 2024 · May 13, 2024 · May 13, 2024
diff --git a/demo/browser/CHANGELOG.md b/demo/browser/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.1.19](https://github.com/adaltas/node-csv/compare/csv-demo-browser@0.1.18...csv-demo-browser@0.1.19) (2024-05-13)
+
+**Note:** Version bump only for package csv-demo-browser
+
+
+
+
+
 ## [0.1.18](https://github.com/adaltas/node-csv/compare/csv-demo-browser@0.1.17...csv-demo-browser@0.1.18) (2024-02-28)
 
 **Note:** Version bump only for package csv-demo-browser

diff --git a/demo/browser/package.json b/demo/browser/package.json
@@ -1,6 +1,6 @@
 {
   "name": "csv-demo-browser",
-  "version": "0.1.18",
+  "version": "0.1.19",
   "main": "index.js",
   "license": "MIT",
   "type": "module",
@@ -20,11 +20,11 @@
     "start": "node server.js"
   },
   "dependencies": {
-    "csv": "^6.3.8",
-    "csv-generate": "^4.4.0",
-    "csv-parse": "^5.5.5",
-    "csv-stringify": "^6.4.6",
+    "csv": "^6.3.9",
+    "csv-generate": "^4.4.1",
+    "csv-parse": "^5.5.6",
+    "csv-stringify": "^6.5.0",
     "express": "^4.18.2",
-    "stream-transform": "^3.3.1"
+    "stream-transform": "^3.3.2"
   }
 }
diff --git a/demo/cjs/CHANGELOG.md b/demo/cjs/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.2.17](https://github.com/adaltas/node-csv/compare/csv-demo-cjs@0.2.16...csv-demo-cjs@0.2.17) (2024-05-13)
+
+**Note:** Version bump only for package csv-demo-cjs
+
+
+
+
+
 ## [0.2.16](https://github.com/adaltas/node-csv/compare/csv-demo-cjs@0.2.15...csv-demo-cjs@0.2.16) (2024-02-28)
 
 **Note:** Version bump only for package csv-demo-cjs

diff --git a/demo/cjs/lib/parse.js b/demo/cjs/lib/parse.js
@@ -1,5 +1,5 @@
 
-const assert = require('assert');
+const assert = require('node:assert');
 const { parse } = require('csv-parse');
 
 const output = [];

diff --git a/demo/cjs/lib/parse.ts b/demo/cjs/lib/parse.ts
@@ -1,5 +1,5 @@
 
-import assert from 'assert'
+import assert from 'node:assert'
 import { parse, Parser } from 'csv-parse'
 
 const output: any = [];

diff --git a/demo/cjs/lib/parse_sync.js b/demo/cjs/lib/parse_sync.js
@@ -1,5 +1,5 @@
 
-const assert = require('assert');
+const assert = require('node:assert');
 const version = parseInt(/^v(\d+)/.exec(process.version)[1], 10)
 const { parse } = require(
   version >= 14 ? 'csv-parse/sync' : 'csv-parse/dist/cjs/sync.cjs'

diff --git a/demo/cjs/lib/parse_sync.ts b/demo/cjs/lib/parse_sync.ts
@@ -1,5 +1,5 @@
 
-import assert from 'assert'
+import assert from 'node:assert'
 // Node.js >= 14
 import { parse } from 'csv-parse/sync'
 // Node.js < 14

diff --git a/demo/cjs/lib/stringify.ts b/demo/cjs/lib/stringify.ts
@@ -1,5 +1,5 @@
 
-import assert from 'assert'
+import assert from 'node:assert'
 import { stringify, Stringifier } from 'csv-stringify';
 
 let output: string = '';

diff --git a/demo/cjs/package.json b/demo/cjs/package.json
@@ -1,14 +1,14 @@
 {
   "name": "csv-demo-cjs",
-  "version": "0.2.16",
+  "version": "0.2.17",
   "main": "index.js",
   "license": "MIT",
   "type": "commonjs",
   "private": true,
   "dependencies": {
-    "csv": "^6.3.8",
-    "csv-parse": "^5.5.5",
-    "csv-stringify": "^6.4.6"
+    "csv": "^6.3.9",
+    "csv-parse": "^5.5.6",
+    "csv-stringify": "^6.5.0"
   },
   "devDependencies": {
     "@types/node": "^20.5.6",

diff --git a/demo/cjs/test/samples.coffee b/demo/cjs/test/samples.coffee
@@ -1,7 +1,7 @@
 
-fs = require 'fs'
-path = require 'path'
-{ exec } = require 'child_process'
+fs = require 'node:fs'
+path = require 'node:path'
+{ spawn } = require 'node:child_process'
 
 dir = path.resolve __dirname, '../lib'
 samples = fs.readdirSync dir
@@ -12,12 +12,16 @@ describe 'Samples', ->
     return false unless /\.(js|ts)?$/.test sample
     true
   .map (sample) ->
-    it "Sample #{sample}", (callback) ->
-      ext = /\.(\w+)?$/.exec(sample)[0]
-      bin = switch ext
-        when '.js'
-          'node'
-        when '.ts'
-          'ts-node' # Also works with:  `node --loader ts-node/esm`
-      exec "#{bin} #{path.resolve dir, sample}", (err, stdout, stderr) ->
-        callback err
+    it "Sample #{sample}", () ->
+      data = await fs.promises.readFile path.resolve(dir, sample), 'utf8'
+      return if /^["|']skip test["|']/.test data
+      new Promise (resolve, reject) ->
+        ext = /\.(\w+)?$/.exec(sample)[0]
+        [cmd, ...args] = switch ext
+          when '.js'
+            ['node', path.resolve dir, sample]
+          when '.ts'
+            ['ts-node', path.resolve dir, sample]
+        spawn(cmd, args)
+          .on 'close', (code) -> if code is 0 then resolve() else reject(new Error 'Failure')
+          .stdout.on 'data', (->)
diff --git a/demo/eslint/CHANGELOG.md b/demo/eslint/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.1.21](https://github.com/adaltas/node-csv/compare/csv-demo-eslint@0.1.20...csv-demo-eslint@0.1.21) (2024-05-13)
+
+**Note:** Version bump only for package csv-demo-eslint
+
+
+
+
+
 ## [0.1.20](https://github.com/adaltas/node-csv/compare/csv-demo-eslint@0.1.19...csv-demo-eslint@0.1.20) (2024-02-27)
 
 **Note:** Version bump only for package csv-demo-eslint

diff --git a/demo/eslint/package.json b/demo/eslint/package.json
@@ -1,6 +1,6 @@
 {
   "name": "csv-demo-eslint",
-  "version": "0.1.20",
+  "version": "0.1.21",
   "description": "",
   "main": "index.js",
   "private": true,
@@ -10,7 +10,7 @@
   },
   "license": "MIT",
   "dependencies": {
-    "csv-stringify": "^6.4.6"
+    "csv-stringify": "^6.5.0"
   },
   "devDependencies": {
     "eslint": "^8.47.0",

diff --git a/demo/esm/CHANGELOG.md b/demo/esm/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.0.31](https://github.com/adaltas/node-csv/compare/csv-demo-esm@0.0.30...csv-demo-esm@0.0.31) (2024-05-13)
+
+**Note:** Version bump only for package csv-demo-esm
+
+
+
+
+
 ## [0.0.30](https://github.com/adaltas/node-csv/compare/csv-demo-esm@0.0.29...csv-demo-esm@0.0.30) (2024-02-28)
 
 **Note:** Version bump only for package csv-demo-esm

diff --git a/demo/esm/package.json b/demo/esm/package.json
@@ -1,13 +1,13 @@
 {
   "name": "csv-demo-esm",
-  "version": "0.0.30",
+  "version": "0.0.31",
   "main": "index.js",
   "license": "MIT",
   "type": "module",
   "private": true,
   "dependencies": {
-    "csv": "^6.3.8",
-    "csv-parse": "^5.5.5"
+    "csv": "^6.3.9",
+    "csv-parse": "^5.5.6"
   },
   "devDependencies": {
     "coffeescript": "^2.7.0",

diff --git a/demo/esm/test/samples.coffee b/demo/esm/test/samples.coffee
@@ -1,12 +1,11 @@
 
-import fs from 'fs'
-import path from 'path'
-import { exec } from 'child_process'
+import fs from 'node:fs/promises'
+import path from 'node:path'
+import { spawn } from 'node:child_process'
 
-import { fileURLToPath } from 'url'
-__dirname = path.dirname fileURLToPath import.meta.url
+__dirname = new URL( '.', import.meta.url).pathname
 dir = path.resolve __dirname, '../lib'
-samples = fs.readdirSync dir
+samples = await fs.readdir dir
 
 describe 'Samples', ->
 
@@ -15,12 +14,17 @@ describe 'Samples', ->
     return false unless /\.(js|ts)?$/.test sample
     true
   .map (sample) ->
-    it "Sample #{sample}", (callback) ->
-      ext = /\.(\w+)?$/.exec(sample)[0]
-      bin = switch ext
-        when '.js'
-          'node'
-        when '.ts'
-          'node --loader ts-node/esm'
-      exec "#{bin} #{path.resolve dir, sample}", (err, stdout, stderr) ->
-        callback err
+
+    it "Sample #{sample}", () ->
+      data = await fs.readFile path.resolve(dir, sample), 'utf8'
+      return if /^["|']skip test["|']/.test data
+      new Promise (resolve, reject) ->
+        ext = /\.(\w+)?$/.exec(sample)[0]
+        [cmd, ...args] = switch ext
+          when '.js'
+            ['node', path.resolve dir, sample]
+          when '.ts'
+            ['node', '--loader', 'ts-node/esm', path.resolve dir, sample]
+        spawn(cmd, args)
+          .on 'close', (code) -> if code is 0 then resolve() else reject(new Error 'Failure')
+          .stdout.on 'data', (->)
diff --git a/demo/issues-cjs/CHANGELOG.md b/demo/issues-cjs/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.2.6](https://github.com/adaltas/node-csv/compare/csv-issues-cjs@0.2.5...csv-issues-cjs@0.2.6) (2024-05-13)
+
+**Note:** Version bump only for package csv-issues-cjs
+
+
+
+
+
 ## [0.2.5](https://github.com/adaltas/node-csv/compare/csv-issues-cjs@0.2.4...csv-issues-cjs@0.2.5) (2024-02-28)
 
 **Note:** Version bump only for package csv-issues-cjs

diff --git a/demo/issues-cjs/package.json b/demo/issues-cjs/package.json
@@ -1,12 +1,12 @@
 {
   "name": "csv-issues-cjs",
-  "version": "0.2.5",
+  "version": "0.2.6",
   "main": "index.js",
   "license": "MIT",
   "private": true,
   "dependencies": {
-    "csv-parse": "^5.5.5",
-    "csv-stringify": "^6.4.6"
+    "csv-parse": "^5.5.6",
+    "csv-stringify": "^6.5.0"
   },
   "devDependencies": {
     "coffeescript": "^2.7.0",

diff --git a/demo/issues-cjs/test/samples.coffee b/demo/issues-cjs/test/samples.coffee
@@ -12,13 +12,16 @@ describe 'Samples', ->
     return false unless /\.(js|ts)?$/.test sample
     true
   .map (sample) ->
-    it "Sample #{sample}", (callback) ->
-      ext = /\.(\w+)?$/.exec(sample)[0]
-      cmd = switch ext
-        when '.js'
-          'node'
-        when '.ts'
-          'ts-node' # Also works with:  `node --loader ts-node/esm`
-      spawn(cmd, [path.resolve dir, sample])
-        .on 'close', (code) -> callback(code isnt 0 and new Error 'Failure')
-        .stdout.on 'data', (->)
+    it "Sample #{sample}", () ->
+      data = await fs.promises.readFile path.resolve(dir, sample), 'utf8'
+      return if /^["|']skip test["|']/.test data
+      new Promise (resolve, reject) ->
+        ext = /\.(\w+)?$/.exec(sample)[0]
+        [cmd, ...args] = switch ext
+          when '.js'
+            ['node', path.resolve dir, sample]
+          when '.ts'
+            ['node', '--loader', 'ts-node/esm', path.resolve dir, sample]
+        spawn(cmd, args)
+          .on 'close', (code) -> if code is 0 then resolve() else reject(new Error 'Failure')
+          .stdout.on 'data', (->)
diff --git a/demo/issues-esm/CHANGELOG.md b/demo/issues-esm/CHANGELOG.md
@@ -3,6 +3,22 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [0.3.0](https://github.com/adaltas/node-csv/compare/csv-issues-esm@0.2.1...csv-issues-esm@0.3.0) (2024-05-13)
+
+
+### Features
+
+* **csv-issues-esm:** issue 411 reproductible 2nd attempt ([41fca27](https://github.com/adaltas/node-csv/commit/41fca279cb10e7bb1a97e09c301e52cfd07856f0))
+* **csv-issues-esm:** issue 411 reproductible attempt ([6c5cb5e](https://github.com/adaltas/node-csv/commit/6c5cb5efb333ed0f6e3f64d2a8cddb2d4f813521))
+* **csv-issues-esm:** issue 423 ([c255eb5](https://github.com/adaltas/node-csv/commit/c255eb57015f821c4dea6558ddb5f58ae908b616))
+
+
+### Bug Fixes
+
+* **csv-parse:** skip event not raised with bom (fix [#411](https://github.com/adaltas/node-csv/issues/411)) ([1326351](https://github.com/adaltas/node-csv/commit/13263514ef6ec02000cf2da39ba6aa2ff92f00ae))
+
+
+
 ## [0.2.1](https://github.com/adaltas/node-csv/compare/csv-issues-esm@0.2.0...csv-issues-esm@0.2.1) (2024-02-28)
 
 

diff --git a/demo/issues-esm/lib/411.csv b/demo/issues-esm/lib/411.csv
@@ -0,0 +1,4 @@
+id,first_name,last_name,email,modified_at
+1,Ring,Grinyov,rgrinyov0@weebly.com,2022-02-14
+2,Kylie,Lauderdale,klauderdale1@wsj.com,2022-02-14,
+3,Cammi,Bendix,cbendix2@tuttocitta.it,2022-02-14
diff --git a/demo/issues-esm/lib/411.js b/demo/issues-esm/lib/411.js
@@ -0,0 +1,27 @@
+import assert from 'node:assert';
+import { createReadStream } from 'node:fs';
+import { Writable } from 'node:stream'
+import { finished } from 'node:stream/promises';
+import desm from "desm";
+import { parse } from 'csv-parse';
+
+const __dirname = desm(import.meta.url);
+const errors = []
+
+const parser = parse({
+  bom: true,
+  skipRecordsWithError: true,
+});
+// Create a stream and consume its source
+const sink = new Writable ({objectMode: true, write: (_, __, callback) => callback()})
+const outStream = createReadStream(`${__dirname}/411.csv`).pipe(parser).pipe(sink);
+// Catch records with errors
+parser.on('skip', (e) => {
+  errors.push(e);
+});
+// Wait for stream to be consumed
+await finished(outStream);
+// Catch error from skip event
+assert.deepStrictEqual(errors.map(e => e.message), [
+  'Invalid Record Length: expect 5, got 6 on line 3'
+])