Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Option for User-Agent #14

Open
sommer-gei opened this issue Nov 26, 2021 · 4 comments
Open

[Feature Request] Add Option for User-Agent #14

sommer-gei opened this issue Nov 26, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@sommer-gei
Copy link

sommer-gei commented Nov 26, 2021

Hey Adam, thank you for your nice little script! :-)

I ran into the problem that the website I'd like to fetch all URLs from blocked the default wget User-Agent (currently "Wget/1.20.3 (linux-gnu)").
To progress with my task I manually changed your (current) script and added a User-Agent string (to the wget command) and it worked very well.

Question: Are you willing to add an option for the User-Agent?

If yes, I would prepare a PR … :-)

KR

@sommer-gei sommer-gei added the enhancement New feature or request label Nov 26, 2021
@adamdehaven
Copy link
Owner

Sure, feel free to submit a PR

@sommer-gei
Copy link
Author

FYI: In the meantime I (temp.) changed the User-Agent with a local ~/.wgetrc file with this content

user-agent = "Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0"

@adamdehaven
Copy link
Owner

@sommer-gei did you ever prepare the Pull Request? I'm happy to add as an option if you want to submit the changes; just please limit the changes to only adding the User Agent option

@sommer-gei
Copy link
Author

@adamdehaven Nope, ATM no PR. :-/

(Changing the wget UA manually in the script code is no problem. Implementing/adding the UA as a script CLI parameter is more complex as I thought … #sry)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants