{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":47707342,"defaultBranch":"master","name":"node","ownerLogin":"addaleax","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2015-12-09T17:26:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/899444?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1713953406.0","currentOid":""},"activityList":{"items":[{"before":"e3d8fb7bebe135985afbb2de08ed5c69c5390802","after":"a8374776c2c18ab6280a2a8971b17a459d79b1e2","ref":"refs/heads/test-cluster-master-error","pushedAt":"2024-05-05T12:09:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aduh95","name":"Antoine du Hamel","path":"/aduh95","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/14309773?s=80&v=4"},"commit":{"message":"test: refactor test-cluster-master-error to be more resilient\n\nUsing the filesystem for communication circumvents the issue\ndescribed in the comment where a new process could end up picking up\nthe process ids that the test case checks for.","shortMessageHtmlLink":"test: refactor test-cluster-master-error to be more resilient"}},{"before":"1df85a8d3166752ff8d53dbd3340a20c39874a22","after":null,"ref":"refs/heads/embedder-snapshot-data-from-blob-string-view","pushedAt":"2024-04-24T10:10:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"}},{"before":null,"after":"1df85a8d3166752ff8d53dbd3340a20c39874a22","ref":"refs/heads/embedder-snapshot-data-from-blob-string-view","pushedAt":"2024-04-19T15:18:39.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"src: add `string_view` overload to snapshot FromBlob\n\nThe `const std::vector&` variant only delegates to a method\nthat converts it to a `std::string_view` anyway, but adding this\ncapability to the public API as well means that it’s easier to\nstore snapshot data in embedding applications (because using\n`std::vector<>` enforces heap allocation and `std::string_view`\ndoes not).","shortMessageHtmlLink":"src: add string_view overload to snapshot FromBlob"}},{"before":"b9195b6e47752322bc716bf4fba2177b3989a1d8","after":null,"ref":"refs/heads/snapshot-cwd-accessed-from-inside-serialize-callback","pushedAt":"2024-03-01T13:10:14.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"}},{"before":"6e7903a74f15f12735ed342df4d9ff531c1492d9","after":"b9195b6e47752322bc716bf4fba2177b3989a1d8","ref":"refs/heads/snapshot-cwd-accessed-from-inside-serialize-callback","pushedAt":"2024-02-27T20:49:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"lib: account for cwd access from snapshot serialization cb\n\nFunctions registered with `addSerializeCallback()` can access and call\n`process.cwd()`. b7d836e2c7f57 accounted for the fact that it is\nnecessary to reset the cwd cache after the snapshot builder script has\nrun, but did not account for possible accesses from serialization\ncallbacks. To properly account for these, add a deserialization\ncallback as well.\n\nAs a related drive-by fix, also mention the execution order of\ncallbacks in the documentation.\n\nRefs: https://github.com/nodejs/node/pull/49684","shortMessageHtmlLink":"lib: account for cwd access from snapshot serialization cb"}},{"before":null,"after":"6e7903a74f15f12735ed342df4d9ff531c1492d9","ref":"refs/heads/snapshot-cwd-accessed-from-inside-serialize-callback","pushedAt":"2024-02-27T20:48:13.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"lib: account for cwd access from snapshot serialization cb\n\nFunctions registered with `addSerializeCallback()` can access and call\n`process.cwd()`. b7d836e2c7f57 accounted for the fact that it is\nnecessary to reset the cwd cache after the snapshot builder script has\nrun, but did not account for possible accesses from serialization\ncallbacks. To properly account for these, add a deserialization\ncallback as well.\n\nAs a related drive-by fix, also mention the execution order of\ncallbacks in the documentation.","shortMessageHtmlLink":"lib: account for cwd access from snapshot serialization cb"}},{"before":"a117a3cf7360090d7e75ebe845ca6ab5d110c6db","after":"ba0b08da6214e9557508fe21b403a82a05dc5b37","ref":"refs/heads/snapshot-config-docs","pushedAt":"2023-11-21T11:53:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"fixup: suggestion for documentation","shortMessageHtmlLink":"fixup: suggestion for documentation"}},{"before":null,"after":"a117a3cf7360090d7e75ebe845ca6ab5d110c6db","ref":"refs/heads/snapshot-config-docs","pushedAt":"2023-11-21T11:53:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"fixup: suggestion for documentation","shortMessageHtmlLink":"fixup: suggestion for documentation"}},{"before":"225c8ab0c7a0eb00482523cdcf1d7559592b4c7c","after":null,"ref":"refs/heads/doc-esm-setEncoding","pushedAt":"2023-04-14T16:22:36.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"}},{"before":null,"after":"225c8ab0c7a0eb00482523cdcf1d7559592b4c7c","ref":"refs/heads/doc-esm-setEncoding","pushedAt":"2023-04-14T08:27:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"doc: add missing setEncoding call in ESM example\n\nAdding `setEncoding()` ensures that the example handles characters\nsplit across chunk boundaries well.","shortMessageHtmlLink":"doc: add missing setEncoding call in ESM example"}},{"before":"afd955026d8809bd23bbda7a6ba6f336c5755bdd","after":null,"ref":"refs/heads/url-stdarray-argv","pushedAt":"2023-03-13T20:45:23.912Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"}},{"before":null,"after":"afd955026d8809bd23bbda7a6ba6f336c5755bdd","ref":"refs/heads/url-stdarray-argv","pushedAt":"2023-03-10T14:47:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"addaleax","name":"Anna Henningsen","path":"/addaleax","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/899444?s=80&v=4"},"commit":{"message":"src: use std::array for passing argv in node::url\n\nImplements a review suggestion from 72e971ee2e7d1c974.\n\nRefs: https://github.com/nodejs/node/pull/47001#issuecomment-1462999332","shortMessageHtmlLink":"src: use std::array for passing argv in node::url"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQdJsmwA","startCursor":null,"endCursor":null}},"title":"Activity · addaleax/node"}