From 2d847d273970f5087d7760de728199c8d5b4e922 Mon Sep 17 00:00:00 2001 From: Anna Henningsen Date: Tue, 9 Oct 2018 10:39:27 -0700 Subject: [PATCH] test: move some gc tests back to parallel/, unmark flaky These should no longer be flaky after the libuv update. Refs: https://github.com/nodejs/node/pull/23336 --- .../test-gc-http-client-connaborted.js | 0 .../test-gc-http-client-onerror.js | 0 .../test-gc-http-client-timeout.js | 0 test/{sequential => parallel}/test-gc-net-timeout.js | 0 test/sequential/sequential.status | 11 ----------- 5 files changed, 11 deletions(-) rename test/{sequential => parallel}/test-gc-http-client-connaborted.js (100%) rename test/{sequential => parallel}/test-gc-http-client-onerror.js (100%) rename test/{sequential => parallel}/test-gc-http-client-timeout.js (100%) rename test/{sequential => parallel}/test-gc-net-timeout.js (100%) diff --git a/test/sequential/test-gc-http-client-connaborted.js b/test/parallel/test-gc-http-client-connaborted.js similarity index 100% rename from test/sequential/test-gc-http-client-connaborted.js rename to test/parallel/test-gc-http-client-connaborted.js diff --git a/test/sequential/test-gc-http-client-onerror.js b/test/parallel/test-gc-http-client-onerror.js similarity index 100% rename from test/sequential/test-gc-http-client-onerror.js rename to test/parallel/test-gc-http-client-onerror.js diff --git a/test/sequential/test-gc-http-client-timeout.js b/test/parallel/test-gc-http-client-timeout.js similarity index 100% rename from test/sequential/test-gc-http-client-timeout.js rename to test/parallel/test-gc-http-client-timeout.js diff --git a/test/sequential/test-gc-net-timeout.js b/test/parallel/test-gc-net-timeout.js similarity index 100% rename from test/sequential/test-gc-net-timeout.js rename to test/parallel/test-gc-net-timeout.js diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 4b7e92331e7b1a..7ba0bb09612b60 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -5,19 +5,8 @@ prefix sequential # sample-test : PASS,FLAKY [true] # This section applies to all platforms -# This test will be flaky until https://github.com/libuv/libuv/pull/1742 lands -# on Node.js. -test-fs-readfile-tostring-fail: PASS, FLAKY -# https://github.com/nodejs/node/issues/23066 -test-gc-http-client-timeout: PASS, FLAKY # https://github.com/nodejs/node/issues/22336 test-gc-http-client: PASS,FLAKY -# https://github.com/nodejs/node/issues/23067 -test-gc-net-timeout: PASS,FLAKY -# https://github.com/nodejs/node/issues/23089 -test-gc-http-client-onerror: PASS,FLAKY -# https://github.com/nodejs/node/issues/23219 -test-gc-http-client-connaborted: PASS,FLAKY [$system==win32] # https://github.com/nodejs/node/issues/22327