From c0b88fc3afa6c3f9d00c181210bace0ef5f7f2af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Zl=C3=A1mal?= Date: Fri, 8 Nov 2019 22:36:28 +0100 Subject: [PATCH] Eslint: re-enable 'jest/valid-title' rule See: https://github.com/jest-community/eslint-plugin-jest/issues/470#issuecomment-551989381 adeira-source-id: 594a91ef3798662ca61379abbba0ef7b6d04117b --- __tests__/__snapshots__/index.test.js.snap | 7 ++++++- ourRules.js | 2 +- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/__tests__/__snapshots__/index.test.js.snap b/__tests__/__snapshots__/index.test.js.snap index 16b8e48..b17f15c 100644 --- a/__tests__/__snapshots__/index.test.js.snap +++ b/__tests__/__snapshots__/index.test.js.snap @@ -297,7 +297,7 @@ Object { "jest/valid-describe": 2, "jest/valid-expect": 2, "jest/valid-expect-in-promise": 2, - "jest/valid-title": 0, + "jest/valid-title": 1, "jsx-a11y/accessible-emoji": 2, "jsx-a11y/alt-text": 2, "jsx-a11y/anchor-has-content": 0, @@ -913,6 +913,11 @@ Snapshot Diff: - "jest/prefer-hooks-on-top": 1, + "jest/prefer-hooks-on-top": 2, "jest/prefer-inline-snapshots": 0, +@@ --- --- @@ + "jest/valid-expect-in-promise": 2, +- "jest/valid-title": 1, ++ "jest/valid-title": 2, + "jsx-a11y/accessible-emoji": 2, @@ --- --- @@ "no-implied-eval": 2, - "no-import-assign": 1, diff --git a/ourRules.js b/ourRules.js index 823faad..ebb82b8 100644 --- a/ourRules.js +++ b/ourRules.js @@ -319,7 +319,7 @@ module.exports = { 'jest/valid-describe': ERROR, 'jest/valid-expect': ERROR, 'jest/valid-expect-in-promise': ERROR, - 'jest/valid-title': OFF, // See: https://github.com/jest-community/eslint-plugin-jest/issues/470 + 'jest/valid-title': NEXT_VERSION_ERROR, // prefer-object-spread (https://github.com/bryanrsmith/eslint-plugin-prefer-object-spread) 'prefer-object-spread/prefer-object-spread': WARN,