diff --git a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap index 16b8e48ef8..b17f15c374 100644 --- a/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap +++ b/src/eslint-config-adeira/__tests__/__snapshots__/index.test.js.snap @@ -297,7 +297,7 @@ Object { "jest/valid-describe": 2, "jest/valid-expect": 2, "jest/valid-expect-in-promise": 2, - "jest/valid-title": 0, + "jest/valid-title": 1, "jsx-a11y/accessible-emoji": 2, "jsx-a11y/alt-text": 2, "jsx-a11y/anchor-has-content": 0, @@ -913,6 +913,11 @@ Snapshot Diff: - "jest/prefer-hooks-on-top": 1, + "jest/prefer-hooks-on-top": 2, "jest/prefer-inline-snapshots": 0, +@@ --- --- @@ + "jest/valid-expect-in-promise": 2, +- "jest/valid-title": 1, ++ "jest/valid-title": 2, + "jsx-a11y/accessible-emoji": 2, @@ --- --- @@ "no-implied-eval": 2, - "no-import-assign": 1, diff --git a/src/eslint-config-adeira/ourRules.js b/src/eslint-config-adeira/ourRules.js index 823faad653..ebb82b832c 100644 --- a/src/eslint-config-adeira/ourRules.js +++ b/src/eslint-config-adeira/ourRules.js @@ -319,7 +319,7 @@ module.exports = { 'jest/valid-describe': ERROR, 'jest/valid-expect': ERROR, 'jest/valid-expect-in-promise': ERROR, - 'jest/valid-title': OFF, // See: https://github.com/jest-community/eslint-plugin-jest/issues/470 + 'jest/valid-title': NEXT_VERSION_ERROR, // prefer-object-spread (https://github.com/bryanrsmith/eslint-plugin-prefer-object-spread) 'prefer-object-spread/prefer-object-spread': WARN, diff --git a/src/monorepo-scanner/src/scans/Babel.scan.js b/src/monorepo-scanner/src/scans/Babel.scan.js index 04d066bb57..04137b80d3 100644 --- a/src/monorepo-scanner/src/scans/Babel.scan.js +++ b/src/monorepo-scanner/src/scans/Babel.scan.js @@ -9,7 +9,7 @@ Workspaces.iterateWorkspaces(packageJSONLocation => { const packageJSON = require(packageJSONLocation); const workspacePath = path.dirname(packageJSONLocation); - test(packageJSON.name, () => { + test(`${packageJSON.name}`, () => { expect(fs.existsSync(path.join(workspacePath, '.babelrc')) === false).toGiveHelp( `Your workspace ${packageJSON.name} contains file '.babelrc' but it should have '.babelrc.js' file instead.`, ); diff --git a/src/monorepo-scanner/src/scans/Changelogs.DISABLED.js b/src/monorepo-scanner/src/scans/Changelogs.DISABLED.js index ec25d6e118..3808e08ca9 100644 --- a/src/monorepo-scanner/src/scans/Changelogs.DISABLED.js +++ b/src/monorepo-scanner/src/scans/Changelogs.DISABLED.js @@ -15,7 +15,7 @@ Workspaces.iterateWorkspaces(packageJSONLocation => { if (semver.gte(packageJson.version, '1.1.0')) { const changelogPath = path.join(packagePath, 'CHANGELOG.md'); - test(changelogPath, () => { + test(`${changelogPath}`, () => { expect(fs.existsSync(changelogPath) === true).toGiveHelp( `Changelog doesn't exist: ${changelogPath}`, ); diff --git a/src/monorepo-scanner/src/scans/NextjsApplications.scan.js b/src/monorepo-scanner/src/scans/NextjsApplications.scan.js index d77f30b664..fd688171e3 100644 --- a/src/monorepo-scanner/src/scans/NextjsApplications.scan.js +++ b/src/monorepo-scanner/src/scans/NextjsApplications.scan.js @@ -16,7 +16,7 @@ Workspaces.iterateWorkspaces(packageJSONLocation => { const babelRCFile = '.babelrc.js'; const babelRCLocation = path.join(workspaceLocation, babelRCFile); - test(babelRCLocation, () => { + test(`${babelRCLocation}`, () => { expect(fs.existsSync(babelRCLocation)).toGiveHelp( `Your Next.js application ${appName} should contain '${babelRCFile}' file in the workspace root.`, ); diff --git a/src/monorepo-scanner/src/scans/Workspaces.scan.js b/src/monorepo-scanner/src/scans/Workspaces.scan.js index b90a7c36c6..1c090ebabc 100644 --- a/src/monorepo-scanner/src/scans/Workspaces.scan.js +++ b/src/monorepo-scanner/src/scans/Workspaces.scan.js @@ -5,7 +5,7 @@ import path from 'path'; import { Workspaces } from '@adeira/monorepo-utils'; Workspaces.iterateWorkspaces(packageJSONLocation => { - test(packageJSONLocation, () => { + test(`${packageJSONLocation}`, () => { // $FlowAllowDynamicImport const packageJson = require(packageJSONLocation); expect(packageJson.private).not.toBeUndefined(); diff --git a/src/monorepo-scanner/src/scans/WorkspacesDependencies.scan.js b/src/monorepo-scanner/src/scans/WorkspacesDependencies.scan.js index 9424970184..4bf6cfdb35 100644 --- a/src/monorepo-scanner/src/scans/WorkspacesDependencies.scan.js +++ b/src/monorepo-scanner/src/scans/WorkspacesDependencies.scan.js @@ -42,7 +42,7 @@ const exceptions = new Map([ describe('dependencies similarities', () => { Workspaces.iterateWorkspaces(packageJSONLocation => { - test(packageJSONLocation, done => { + test(`${packageJSONLocation}`, done => { // $FlowAllowDynamicImport const packageJson = require(packageJSONLocation); const dependencies = Object.keys(packageJson.dependencies || {});