New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@adeira/relay: fetch-schema script should support .babelrc #189
Comments
You should upgrade to Babel 7 properly by using project-wide configuration I encountered this issue as well on one project and I am not sure we should modify it in this package (it's simple, we'd have to use root mode |
of course 🙂 possible solution can be also upgrading error message explaining this :) |
Sure, feel free to send a PR to Babel since this is nothing Universe specific. :) |
Closed via babel/babel#10778 |
Very nice! 👍 |
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
This will also be allowed from our side: #203 (if it goes through the review) It's because the code which is enforcing the "upward" mode is necessary only for Universe development and should not affect our NPM users. So I changed my mind and now I think this issue is very valid. Thank you for your contribution into Babel itself though - that's really great no matter this change! :) |
Side note: I believe it's still valid to use project-wide config for Babel 7+ projects... :) |
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
This feature was requested here #189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package.
This feature was requested here adeira/universe#189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package. adeira-source-id: a7917273c3a7861fa3f355e38c9ab732a9b1d150
This feature was requested here adeira/universe#189 and was greatly improved in Babel itself here babel/babel#10778. It can however be annoying and sometimes difficult to do such modification so I changed my mind and I'd like to allow it after all. It's because this code where we require "upward" mode is necessary only for Universe development and should not affect users of our NPM package. adeira-source-id: a7917273c3a7861fa3f355e38c9ab732a9b1d150
When running adeira-fetch-schema on repository with
.babelrc
only, it fails to find babel config:The text was updated successfully, but these errors were encountered: