Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal is flaky in testing #1224

Open
Yelinz opened this issue Apr 19, 2024 · 0 comments
Open

Modal is flaky in testing #1224

Yelinz opened this issue Apr 19, 2024 · 0 comments
Labels

Comments

@Yelinz
Copy link
Member

Yelinz commented Apr 19, 2024

if (typeof this.args.container !== "string") {
return container.selector ?? "body";
}

Probably needs to have a testing condition. Which returns #ember-testing as the selector in tests, as that is the correct container.

@Yelinz Yelinz added the bug label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant