Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transforms.Time should return datetime.time #23

Open
c0rydoras opened this issue Nov 14, 2023 · 0 comments
Open

transforms.Time should return datetime.time #23

c0rydoras opened this issue Nov 14, 2023 · 0 comments
Assignees
Labels
breaking breaking change / removal removal removal request / implementation
Milestone

Comments

@c0rydoras
Copy link
Collaborator

def __init__(self, return_datetime: bool = False):
# return_datetime will be removed at some point
# it defaults to True to maintain backwards compatibility
self.return_datetime = return_datetime

Time transform should return a datetime.time instead of a datetime.datetime(1900, 1, 1, time.hours, time.minutes, time.seconds). (see #17)

@c0rydoras c0rydoras self-assigned this Nov 14, 2023
@c0rydoras c0rydoras added breaking breaking change / removal removal removal request / implementation labels Nov 14, 2023
@c0rydoras c0rydoras added this to the libtimed v1 milestone Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking breaking change / removal removal removal request / implementation
Projects
None yet
Development

No branches or pull requests

1 participant