Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Rename folder php to webapp or project or similar #36

Open
gogl92 opened this issue Dec 4, 2022 · 2 comments
Open

Suggestion: Rename folder php to webapp or project or similar #36

gogl92 opened this issue Dec 4, 2022 · 2 comments

Comments

@gogl92
Copy link

gogl92 commented Dec 4, 2022

When I try to containerize my own project I have to store in a different place the php-fpm.ini that is inside the php folder , delete the index.php, copy my code into the php folder and add back the php-fpm.ini, I feel like the structure should be more like:

root 
       --- php 
             --- php-fpm.ini
       --- webapp
             --- index.php (or the files of the project to be containerized) 

In this structure we keep the php config files in a different location than the php code files.

so that in the Dockerfiles we can copy all the files inside the project folder, so instead of

COPY php/index.php /var/www/html/index.php

we can do something like

COPY ./php/. /var/www/html/

to copy all the files

@adhocore
Copy link
Owner

adhocore commented Dec 6, 2022

oh actually that is just the path for lemp stack not the application source code. the index.php is just a default landing page to show "it works". the actual app should instead directly volume map to /var/www/html. hope this helps. :)

@gogl92
Copy link
Author

gogl92 commented Dec 6, 2022

@adhocore oh got it, the way I use this project is: I clone the project put the code of my project in the PHP folder and then build the docker image then I distribute the image to the frontend devs or submit it to Google cloud to deploy it into an instance for the QA team, I know maybe this isn't the intention of the repo but it has been working for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants