Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable retry error code #548

Open
RLovelett opened this issue Aug 15, 2018 · 2 comments
Open

Configurable retry error code #548

RLovelett opened this issue Aug 15, 2018 · 2 comments

Comments

@RLovelett
Copy link

RLovelett commented Aug 15, 2018

I want wd to retry on ECONNREFUSED in wd/lib/http-utils.js.

As of right now this does not seem possible.

The paths forward seem like:

  1. Modify the function shouldRetryOn to explicitly cover the ECONNREFUSED error code.
  2. Make it configurable via configureHttp and add it as an additional argument to shouldRetryOn.
  3. Something else I have not thought of?

Before I make a PR is there a preference for either 1 or 2?

@admc
Copy link
Owner

admc commented Aug 16, 2018

@jlipps thoughts?

@jlipps
Copy link
Collaborator

jlipps commented Sep 28, 2018

i think i'd prefer option 2, since usually econnrefused means the server is not on and we want to provide that feedback immediately without bothering to retry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants