Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Range header handling with Spring's HttpRange #1174

Merged
merged 7 commits into from
Jun 23, 2023
Merged

Correct Range header handling with Spring's HttpRange #1174

merged 7 commits into from
Jun 23, 2023
+320 −375

Conversation

afranken
Copy link
Member

Description

  • Use Spring's HttpRange class for range handling in APIs
  • Add range integration tests
  • Unrelated minor fixes for existing classes

Related Issue

#1172 #1131

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

Sorry, something went wrong.

@afranken afranken self-assigned this Jun 17, 2023
@afranken afranken changed the title 1172 rfc 9110 ranges Correct Range header handling with Spring's HttpRange Jun 17, 2023
afranken added 6 commits June 19, 2023 22:50
@afranken
Remove outdated and wrong documentation from tests.
6c70ffa
@afranken
Add range integration tests V2
d589002 
Some are currently unsupported, @disable until later.

#1172
@afranken
Add #toString() for debug logging
c50deba 
This should be helpful for debugging issues both through logs and when
stepping in the debugger in an IDE.
@afranken
Use Spring's HttpRange class for range handling in APIs
6e17c31 
A simple header converter is all that's needed, S3 API does not allow
more than one byte range.
Not sure why we had a custom range parser implementation when there's
one in the framework we depend on.

Fixes #1172 and #1131
@afranken
Remove unused class from integration tests
d836860
@afranken
Add @S3VerifiedTodo to mark unverified tests
c1a1ae7 
Some older tests have yet to be verified.
Also added documentation to existing classes.
@afranken afranken force-pushed the 1172-rfc-9110-ranges branch from 435e05e to c1a1ae7 Compare June 19, 2023 20:52
@afranken afranken merged commit c88fe53 into main Jun 23, 2023
@afranken afranken deleted the 1172-rfc-9110-ranges branch June 23, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@afranken afranken

Labels
feature housekeeping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@afranken