Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pathStyleAccess=false / bucket subdomains #144

Open
agudian opened this issue May 10, 2019 · 0 comments · May be fixed by #925
Open

Support pathStyleAccess=false / bucket subdomains #144

agudian opened this issue May 10, 2019 · 0 comments · May be fixed by #925
Assignees
@afranken
Labels
feature help wanted

Comments

@agudian
Copy link
Member

agudian commented May 10, 2019

AWS has announced to deprecate pathStyleAccess in the foreseeable future.

The S3 mock server could support that when running in Docker, with properly configured Docker network and alias settings, and then maybe checking the request for the used subdomain name.

Dynamically creating buckets won't be possible, though.

The challenge is to do that without having to duplicate the complete API controller and to provide proper testing within the Maven build.
@agudian agudian mentioned this issue May 10, 2019
Closed
@agudian agudian mentioned this issue May 10, 2019
Closed
@agudian agudian mentioned this issue Apr 23, 2021
Closed
@afranken afranken self-assigned this Sep 29, 2022
@afranken afranken mentioned this issue Oct 31, 2022
Closed
@afranken afranken mentioned this issue Nov 11, 2022
Merged
2 tasks
afranken added a commit that referenced this issue Nov 21, 2022
@afranken
BucketNameFilter to access bucket name in domain
7fd5d2c 
BucketNameFilter will extract the bucket name from subdomain or path and
add it as a request attribute for consumption in handler methods.

Fixes #144
@afranken afranken linked a pull request Nov 21, 2022 that will close this issue
Draft
2 tasks
afranken added a commit that referenced this issue Nov 21, 2022
@afranken
WIP - Consume BucketName request attribute
7550de3 
Trying out if this works (BucketNameFilter will take name from path),
assert that bucket name is the same that is passed in the path to the
handler method.

Fixes #144
afranken added a commit that referenced this issue Nov 24, 2022
@afranken
BucketNameFilter to access bucket name in domain
b174e45 
BucketNameFilter will extract the bucket name from subdomain or path and
add it as a request attribute for consumption in handler methods.

Fixes #144
afranken added a commit that referenced this issue Nov 24, 2022
@afranken
WIP - Consume BucketName request attribute
b151edb 
Trying out if this works (BucketNameFilter will take name from path),
assert that bucket name is the same that is passed in the path to the
handler method.

Fixes #144
afranken added a commit that referenced this issue Dec 21, 2022
@afranken
BucketNameFilter to access bucket name in domain
3e238d0 
BucketNameFilter will extract the bucket name from subdomain or path and
add it as a request attribute for consumption in handler methods.

Fixes #144
afranken added a commit that referenced this issue Dec 21, 2022
@afranken
WIP - Consume BucketName request attribute
5984ed0 
Trying out if this works (BucketNameFilter will take name from path),
assert that bucket name is the same that is passed in the path to the
handler method.

Fixes #144
@afranken afranken mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afranken afranken

Labels
feature help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP - Enable subdomain access for buckets adobe/S3Mock
2 participants
@afranken @agudian