Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check of the hash of aem.js as part of the git PR workflow? #272

Open
shsteimer opened this issue Oct 19, 2023 · 1 comment
Open

Comments

@shsteimer
Copy link

Consider this an idea more than concrete proposal

I've run across a number of ACS and partner projects who are modifying aem.js as their default way of changing things, as opposed to doing it in scripts.js. I view modifying aem.js as not necessarily verboten, but to be avoided when possible.

But my thought would be to have the PR workflow check the hash against a known value, and if it doesn't match, print a message indicating to use caution when modifying, etc.

If the project really wants to or needs to, they can update the hash in the pr script and move on, but should at least encourage the right behavior. thoughts?

@amol-anand
Copy link
Contributor

amol-anand commented Nov 1, 2023

If the project really wants to or needs to, they can update the hash in the pr script and move on, but should at least encourage the right behavior. thoughts?

It can also be more of a warning that can be overridden similar to PSI check today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants