Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download dialog showing invalid description from asset #2749

Open
HitmanInWis opened this issue May 7, 2024 · 0 comments
Open

Download dialog showing invalid description from asset #2749

HitmanInWis opened this issue May 7, 2024 · 0 comments

Comments

@HitmanInWis
Copy link

Bug present as of version: 2.24.7-SNAPSHOT

On the Download component dialog, if you select a DAM asset with a Title but no Description, the Title value is displayed in both the Title (correct) and Description (incorrect) fields when the checkboxes to default from DAM are selected. However, on closing the dialog, the Description on the component displays empty (b/c there is no actual description on the DAM Asset).

One solution is to simply update the dialog to no longer display the DAM Asset title in the Description field:

Bug File: /apps/core/wcm/components/download/v1/download/clientlibs/editor/js/download.js

Remove the following lines of code from the retrieveDAMInfo function:

                    if (description === undefined || description.trim() === "") {
                        description = data["dc:title"];
                    }

If, however, there is a valid reason to have the description default from the title, we'd need to instead update how the sling model calculates description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant