Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack config is not reloaded when edited during aio app run #35

Open
shazron opened this issue Feb 8, 2021 · 2 comments
Open

webpack config is not reloaded when edited during aio app run #35

shazron opened this issue Feb 8, 2021 · 2 comments
Assignees
@shazron
Labels
bug Something isn't working deferred Issues and pull requests that require more thought, or add cost/complexity that must be evaluated.

Comments

@shazron
Copy link
Member

shazron commented Feb 8, 2021 •
edited

Expected

The webpack config is reloaded for building the action when edited during aio app run

Actual

The webpack config is not reloaded for building the action when edited during aio app run

Repro

  1. Add a actions/webpack-config.js file, exporting a CommonJS module as a webpack config
  2. Run DEBUG=@adobe/aio-lib-runtime:action-builder:debug aio app run
  3. See the log of the web pack config being loaded
  4. Wait until the 2 urls of your deployed application is logged
  5. Edit actions/webpack-config.js with a new entry/delete an entry
  6. See the log of the web pack config being loaded, it should be different
@shazron
Copy link
Member Author

shazron commented Feb 8, 2021

PR #33

@shazron shazron self-assigned this Feb 8, 2021
@shazron shazron added the bug Something isn't working label Feb 8, 2021
@shazron shazron mentioned this issue Feb 8, 2021
Closed
10 tasks
@aiojbot
Copy link
Collaborator

aiojbot commented Feb 8, 2021

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-1043

@shazron shazron added the deferred Issues and pull requests that require more thought, or add cost/complexity that must be evaluated. label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shazron shazron

Labels
bug Something isn't working deferred Issues and pull requests that require more thought, or add cost/complexity that must be evaluated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove the webpack config module from the require cache adobe/aio-lib-runtime
2 participants
@shazron @aiojbot