Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hlx up should default to the preview domain set in sidekick #2219

Open
davidnuescheler opened this issue Aug 2, 2023 · 7 comments
Open

hlx up should default to the preview domain set in sidekick #2219

davidnuescheler opened this issue Aug 2, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@davidnuescheler
Copy link
Contributor

it would be great if we could automatically use the custom preview URLs for hlx up, i think this would allow devs at customers that have custom preview URLs to work more intuitively with custom CDN layers that are sitting infront of .page

@davidnuescheler davidnuescheler added the enhancement New feature or request label Aug 2, 2023
@davidnuescheler
Copy link
Contributor Author

thoughts @rofe / @tripodsan ?

@tripodsan
Copy link
Contributor

good idea - but there is no possibility to communicate with the sidekick from the helix-cli.....
we could call https://admin.hlx.page/sidekick/.../env.json but this would only work for projects w/o admin authentication

@davidnuescheler
Copy link
Contributor Author

let's add a hlx env file with default options in the github repo / root directory.

@tripodsan
Copy link
Contributor

let's add a hlx env file with default options in the github repo / root directory.

I'm not a big fan of adding even more configuration to the system. note, that devs already can add a HLX_URL=... in their .env to proxy a specific page

tripodsan added a commit that referenced this issue Mar 19, 2024
@tripodsan
Copy link
Contributor

this is fixed.

@3vil3mpir3
Copy link

After testing, AEM up w/out the --url flag doesn't seem to work for customer. It does load adobe origin urls, just not the customer's worker urls

@3vil3mpir3 3vil3mpir3 reopened this Apr 19, 2024
@tripodsan
Copy link
Contributor

@3vil3mpir3 please note, that this doesn't work for authenticated projects. I assume that's why it doesn't work for some customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants