Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use semantic release in my project #2280

Open
kptdobe opened this issue Nov 30, 2023 · 0 comments
Open

Cannot use semantic release in my project #2280

kptdobe opened this issue Nov 30, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Nov 30, 2023

Create a project, setup semantic release and release a version. A shortcut is to create project and create a git tag+release with name v1.0.0 on the latest commit.
Just clone the project (stay on the main branch) and run aem up. This crashes pretty quickly with error:

Hostname/IP does not match certificate's altnames: Host: v1.0.0--my-helix-project--adobe.hlx.page. is not in the cert's altnames: DNS:developer.adobe.com, DNS:www.adobe.io, DNS:adobe.io, DNS:udp.adobe.io, DNS:*.developer.adobe.com, DNS:dev.adobe.com, DNS:*.adobe.io, DNS:developers.adobe.com, DNS:*.developers.adobe.com, DNS:www.developer.adobe.com, DNS:www.developers.adobe.com

image

A quick inspection took me to: https://github.com/adobe/helix-cli/blob/main/src/git-utils.js#L151-L163
The tag is returned because it matches the commit sha instead of the main branch. And of course v.1.0.0 is not valid in the subdomain host.

3 options:

  1. get rid of the tag logic - not sure when we would need it... the probability that the tag name contains a dot is pretty high
  2. move the branch logic before the tag logic - if you are in a valid branch, no need to check for something else
  3. document we do not support semantic-release at project level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant