Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Cache (just a little bit) when serving Excel #153

Open
trieloff opened this issue Aug 13, 2020 · 2 comments
Open

Cache (just a little bit) when serving Excel #153

trieloff opened this issue Aug 13, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@trieloff
Copy link
Contributor

Partial revert of #131 so that rate limit issues with Sharepoint can be avoided. Sharepoint's default back-off time is two minutes, which is a reasonable default.
@trieloff trieloff added the bug Something isn't working label Aug 13, 2020
@tripodsan
Copy link
Contributor

but 2 minutes is too long for the query-index, for example.
it should be possible to enable/disable caching. e.g. requesting through the content-proxy doesn't cache.

@trieloff
Copy link
Contributor Author

What about a pair of parameters? cache.max and cache.min?

trieloff added a commit to adobe/helix-content-proxy that referenced this issue Aug 20, 2020
@trieloff
fix(json): request fresh data from helix-data-embed
acece23 
Adobe I/O Runtime respects the `no-cache` directive in the `Cache-Control` *request* header, which will allow us to do a partial revert of adobe/helix-data-embed#131 and keep some caching as the default

see adobe/helix-data-embed#153
@trieloff trieloff mentioned this issue Aug 20, 2020
Merged
trieloff added a commit that referenced this issue Aug 20, 2020
@trieloff
fix(cache): add some minimal cache to prevent 429s
df3ba94 
fixes #153 recommended for adobe/helix-content-proxy#144
@trieloff trieloff mentioned this issue Aug 20, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cache): add some minimal cache to prevent 429s adobe/helix-data-embed
2 participants
@trieloff @tripodsan