Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

simplify multi-sheet responses #374

Open
tripodsan opened this issue May 20, 2021 · 2 comments
Open

simplify multi-sheet responses #374

tripodsan opened this issue May 20, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tripodsan
Copy link
Contributor

tripodsan commented May 20, 2021

in order to remove unexpected, unused properties we should change the format (again):

single sheet response:

HTTP/2 200
content-type: application/json
x-helix-data-version: 4
x-helix-data-type: sheet
x-helix-data-names: sheet1

{
  "offset": 0,
  "limit": 100,
  "total": 200,
  "data": [ ... ]
}

multi sheet response:

HTTP/2 200
content-type: application/json
x-helix-data-version: 4
x-helix-data-type: multi-sheet
x-helix-data-names: sheet1, sheet2

{
  "sheets": {
    "sheet1": {
      "offset": 0,
      "limit": 100,
      "total": 200,
      "data": [
        ...
      ]
    },
    "sheet2": {
      "offset": 0,
      "limit": 100,
      "total": 200,
      "data": [
        ...
      ]
    }
  }
}

/cc @trieloff @davidnuescheler

@tripodsan tripodsan added the enhancement New feature or request label May 20, 2021
@davidnuescheler
Copy link

Let's make sure we wait with this and time it until we have no more use of multiple sheets anymore in production which should be in a couple of weeks.

@tripodsan
Copy link
Contributor Author

ok, so I use the old format in adobe/helix-json-filter#6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants