Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe Linking #53

Open
trieloff opened this issue Jan 3, 2021 · 1 comment
Open

Safe Linking #53

trieloff opened this issue Jan 3, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@trieloff
Copy link
Contributor

trieloff commented Jan 3, 2021

See https://cq-dev.slack.com/archives/CGG9B79BK/p1609701306002100?thread_ts=1609615520.001500&cid=CGG9B79BK

If the v1 link is not pointing to the latest version it is likely that a rollback has been performed. It's probably better not to update links in that case and instead wait for the operator to re-link using action-admin.

@trieloff
Copy link
Contributor Author

trieloff commented Jan 4, 2021

good idea with the safe linking. but this way we cannot easily deploy a fix w/o a special flag ...

There are a number of practical considerations that I didn't want to think through last night:

  • how to indicate you have a fix for that specific rollback
  • how to determine that the linked version is not the last one (without excessive reads)

One possible solution:

  1. When rolling back using the action admin, automatically create a github issue and add the issue URL to the v1 metadata.
  2. As an operator, use the github issue to describe reasoning for the rollback
  3. When attempting to link, check that the github issue has been resolved

The only additional overhead would be to add the fixes #53 line to the commit fixing the issue.

@trieloff trieloff added the enhancement New feature or request label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant