Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws] use account and region specific deploy bucket #568

Open
tripodsan opened this issue Aug 17, 2023 · 0 comments
Open

[aws] use account and region specific deploy bucket #568

tripodsan opened this issue Aug 17, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Aug 17, 2023

the current deploy bucket is prefixed with the accountid, but does not honour the deploy region:

this._bucket = this._cfg.deployBucket || `helix-deploy-bucket-${this._accountId}`;

it seems that function code can only be deployed from a bucket in the same region, hence just using the accountid is not enough to separate the deploy buckets. suggest to construct the default deploy bucket like:

    this._bucket = this._cfg.deployBucket || `helix-deploy-bucket-${this._accountId}-${this._cfg.region}`;
@tripodsan tripodsan added good first issue Good for newcomers enhancement New feature or request labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant