Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move interfaces to own files and provide type declarations #70

Open
tripodsan opened this issue Nov 21, 2019 · 1 comment
Open

Move interfaces to own files and provide type declarations #70

tripodsan opened this issue Nov 21, 2019 · 1 comment
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@tripodsan
Copy link
Contributor

The current log.js is quite large and contains a log of functions and classes.
IMO, at least the interfaces that are not tried to the log module should be refactored in their own files.

An additional bonus would be to provide typescript like type declarations.

@tripodsan tripodsan added the enhancement New feature or request label Nov 21, 2019
@tripodsan tripodsan self-assigned this Nov 21, 2019
@koraa
Copy link
Contributor

koraa commented Nov 21, 2019

Good idea! I have tried splitting log.js multiple times and ran into circular dependency issues.
Maybe you will have more luck!

I think typescript declarations would be a good idea too; should be a separate issue though unless you really want to tackle both at once. If we do that we might provide proper type script interfaces right away…

@tripodsan tripodsan removed their assignment Oct 10, 2022
@tripodsan tripodsan added the wontfix This will not be worked on label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants