Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

sitemap should not return an empty file if indexing isn't configured #304

Open
dominique-pfister opened this issue May 27, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dominique-pfister
Copy link
Contributor

dominique-pfister commented May 27, 2020

Currently, the sitemap is returned from a static file sitemap.xml in the document root, which again ESincludes dynamically generated url sets. If indexing isn't configuring in that project (i.e. no `helix-query.yaml present), an empty list is returned. This is bad, since it e.g. makes Google believe that the site is empty. If a 404 is returned instead, Google will crawl the site manually.

Idea: in robots.txt, use the property Sitemap and point it to /cgi-bin/sitemap.js instead.
Or: in our fastly configuration, redirect /sitemap.xml to /cgi-bin/sitemap.js

@dominique-pfister dominique-pfister self-assigned this May 27, 2020
@dominique-pfister dominique-pfister added the bug Something isn't working label May 27, 2020
@rofe
Copy link
Contributor

rofe commented May 27, 2020

This is bad, since it e.g. makes Google believe that the site is empty

Maybe it's also desired?

In any case, I like the Fastly redirect better so we can stick with the standard file name.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants