Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

remove support for embed #1060

Open
tripodsan opened this issue Apr 21, 2021 · 2 comments
Open

remove support for embed #1060

tripodsan opened this issue Apr 21, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@tripodsan
Copy link
Contributor

the embed feature using ESI includes is very brittle and causes problems often times. embedding is better done clientside.

@tripodsan tripodsan added the enhancement New feature or request label Apr 21, 2021
@kptdobe
Copy link
Contributor

kptdobe commented Apr 27, 2021

For the record: theblog project uses "ESI" embeds. Removing support would mean you potentially break a lot of existing blog posts. Migrating the content is not an option (more than 20k md and docx pages to check and update with the corresponding block).
Only option would be to write some logic to detect those embeds and transform them into block... client side.

@tripodsan
Copy link
Contributor Author

Only option would be to write some logic to detect those embeds and transform them into block... client side.

yes. this will be the option. so we need to prepare the breaking branch accordingly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants