do not assume default ref to be master

[trieloff]

helix-publish/layouts/fastly/helix.vcl

Line 271 in 172a1be

set req.http.X-Ref = "master";

We may be able to just keep it empty since adobe/helix-resolve-git-ref#253 added a default branch fallback

[tripodsan]

would be interesting to see what breaks if no ref is present :-) but I assume it is most of the times read from the strains, so should be present.

a problem will be, if a customer uses a different default branch than helix-pages....

[trieloff]

adobe/helix-pages#491 is the more effective change

[kptdobe]

I do not think the proposed change in adobe/helix-pages#491 is what we need / is enough, especially after my last changes adobe/helix-pages@70b582a.

There are 4 cases to cover at 2 different places:

• branch/repo/owner is provided in url: X-Ref should use the branch
• repo/owner is provided in url: X-Ref should be null so that default branch resolution can happen
• www / helix-pages site is requested (branch/repo/owner is not provided) AND strain_refs is set (case of testing a helix-pages branch): X-Ref should be strain_refs
• www / helix-pages site is requested (branch/repo/owner is not provided) AND strain_refs is null: X-Ref should be null so that default branch resolution can happen

Assuming that "X-Ref should be null so that default branch resolution can happen" is what we need to do in the end.

This requires to also rework this block:

helix-publish/layouts/fastly/helix.vcl

Lines 266 to 272 in 172a1be

	if (!req.http.X-Ref) {
	set req.http.X-Ref = table.lookup(strain_refs, "default");
	}
	# if default isn't set, use 'master'
	if (!req.http.X-Ref) {
	set req.http.X-Ref = "master";
	}

[kptdobe]

which in the end should be simple: logically replace req.http.X-Ref = "master" by unset req.http.X-Ref on side (if might just be removed).

I can look at it next week.