Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return correct total in response to make pagination possible bdf-query #911

Open
MarquiseRosier opened this issue Jul 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@MarquiseRosier
Copy link
Collaborator

MarquiseRosier commented Jul 13, 2023

Description
currently a non-numerical total is returned,

To Reproduce
query rum-pageviews-bdf with an authorized domain key.

Expected behavior
total needs to be numerical like the limit parameter. so we can determine how much info is missing and we need to provide materials for folks to paginate.

Screenshots
Screen Shot 2023-07-13 at 9 04 11 AM

issue raised by David Barrat of the DAAS team.

@MarquiseRosier MarquiseRosier added the bug Something isn't working label Jul 13, 2023
@MarquiseRosier MarquiseRosier self-assigned this Jul 13, 2023
@langswei
Copy link
Collaborator

I believe this relates to #921 which needs to be merged first. Since a change would be required to the file named rum-pageviews-bdf.sql, I'd like to take the opportunity to move it to a folder (bdf@rum-pageviews.sql) which also requires some work in the dash-queries branch to be merged.

@langswei
Copy link
Collaborator

RE: non-numerical values, that is likely due to https://github.com/adobe/helix-run-query/blob/main/src/util.js#L165-L166. My suggestion at this time is to not consider the offset and total fields as having any relation to pagination (which is not implemented at this time).

@langswei langswei mentioned this issue Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants