Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

hlx up fails with node 15.x #566

Closed
tripodsan opened this issue Jan 14, 2021 · 3 comments · Fixed by #567
Closed

hlx up fails with node 15.x #566

tripodsan opened this issue Jan 14, 2021 · 3 comments · Fixed by #567
Assignees
@tripodsan
Labels
bug Something isn't working released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jan 14, 2021 •
edited

creating a copy of the request object fails:

helix-simulator/src/RequestContext.js

Line 24 in e956bae

const req = { ...request, ...cfg.requestOverride };

which leads to:

TypeError: headers.get is not a function
    at getOriginalHost (/Users/uncled/code/pages/.hlx/pages/master/src/utils.js:28:23)
    at getAbsoluteUrl (/Users/uncled/code/pages/.hlx/pages/master/src/utils.js:47:18)

due to: nodejs/node#36550
@tripodsan tripodsan added the bug Something isn't working label Jan 14, 2021
@tripodsan tripodsan self-assigned this Jan 14, 2021
@tripodsan
Copy link
Contributor Author

/cc @davidnuescheler @stefan-guggisberg

tripodsan added a commit that referenced this issue Jan 14, 2021
@tripodsan
fix(server): clone of request object fails with node 15.x
ec96236 
fixes #566
@tripodsan tripodsan mentioned this issue Jan 14, 2021
Merged
tripodsan added a commit that referenced this issue Jan 14, 2021
@tripodsan
fix(server): clone of request object fails with node 15.x (#567)
cbec17b 
fixes #566
github-actions bot pushed a commit that referenced this issue Jan 14, 2021
@semantic-release-bot
chore(release): 5.1.16 [skip ci]
c78150a 
## [5.1.16](v5.1.15...v5.1.16) (2021-01-14)

### Bug Fixes

* **server:** clone of request object fails with node 15.x ([#567](#567)) ([cbec17b](cbec17b)), closes [#566](#566)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.1.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@stefan-guggisberg
Copy link
Contributor

thanks, good to know!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(server): clone of request object fails with node 15.x adobe/helix-simulator
2 participants
@tripodsan @stefan-guggisberg