You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I can listen to sp-closed on overlay-trigger and only get close events for that trigger
Actual behavior
If I use sp-action-menu or sp-picker in the overlay rendered by overlay-trigger, closing these menus also triggers sp-closed for the outer menu. It does look like I can match the event.target to the original trigger button, but I could see this really throwing people for a loop.
How can we reproduce this issue?
I can look at getting a simpler reproduction when I have a bit more time.
The text was updated successfully, but these errors were encountered:
I'm not really sure if another event or better documentation is the right approach here, but it was tricky to figure this out, and I'm curious how this would work for manually triggered overlays as well.
As I think about this more, I think what I'm really asking for is an event that doesn't bubble. I just want to know if this overlay opened or closed. Using the same (bubbling) event that the overlay system gets confusing because it's less common, and surprising when you run into it.
So ideally there's be another event that doesn't bubble, which when documented should make the difference in behavior very clear. And all that said, I won't be too offended if you decide it's just simpler to improve the documentation. Just pointing out that this can be a real surprising gotcha.
Code of conduct
Impacted component(s)
overlay-trigger
Expected behavior
I can listen to
sp-closed
onoverlay-trigger
and only get close events for that triggerActual behavior
If I use sp-action-menu or sp-picker in the overlay rendered by
overlay-trigger
, closing these menus also triggerssp-closed
for the outer menu. It does look like I can match theevent.target
to the original trigger button, but I could see this really throwing people for a loop.How can we reproduce this issue?
I can look at getting a simpler reproduction when I have a bit more time.
The text was updated successfully, but these errors were encountered: