Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Coachmark and Overlay are missing lit dependencies in 0.42.4 release #4454

Closed
1 task done
jcmitch opened this issue May 15, 2024 · 1 comment
Closed
1 task done
Labels
bug Something isn't working triage An issue needing triage

Comments

@jcmitch
Copy link
Contributor

jcmitch commented May 15, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

Coachmark, Overlay

Expected behavior

Should be able to install components without error or without needing to include additional dependencies.

Actual behavior

Error messages when running.

ModuleNotFoundError: Module not found: Error: Can't resolve 'lit/directives/join.js' in '/Users/kellencheng/component-core/packages/spectrum-web-component-fallbacks/dist/coachmark/src'
 
 ---and---
 
 ModuleNotFoundError: Module not found: Error: Can't resolve 'lit/async-directive.js' in '/Users/kellencheng/component-core/packages/spectrum-web-component-fallbacks/dist/overlay/src'

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Attempt to install 0.42.4 outside of an environment which includes lit
  2. Attempt to use Overlay or Coachmark

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

@jcmitch jcmitch added bug Something isn't working triage An issue needing triage labels May 15, 2024
@jcmitch
Copy link
Contributor Author

jcmitch commented May 21, 2024

Fixed in #4455

@jcmitch jcmitch closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

1 participant