-
-
Notifications
You must be signed in to change notification settings - Fork 14
/
csrf.spec.ts
448 lines (362 loc) · 15.2 KB
/
csrf.spec.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
/* eslint-disable unicorn/no-await-expression-member */
/*
* @adonisjs/shield
*
* (c) ? (Please advice before merge, thanks!)
*
* For the full copyright and license information, please app.container.use('Adonis/Core/View') the LICENSE
* file that was distributed with this source code.
*/
import Tokens from 'csrf'
import { Edge } from 'edge.js'
import { test } from '@japa/runner'
import { HttpContextFactory } from '@adonisjs/core/factories/http'
import { SessionMiddlewareFactory } from '@adonisjs/session/factories'
import { setup } from './helpers.js'
import { csrfFactory } from '../src/guards/csrf.js'
import { E_BAD_CSRF_TOKEN } from '../src/errors.js'
import { I18nManagerFactory } from '@adonisjs/i18n/factories'
const tokens = new Tokens()
test.group('Csrf', () => {
test('return noop function when enabled is false', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const csrf = csrfFactory({ enabled: false }, await app.container.make('encryption'))
csrf(ctx)
assert.isUndefined(ctx.request.csrfToken)
})
test('validate csrf token on a request', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'POST'
})
const csrf = csrfFactory({ enabled: true }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('skip validation when request method is not one of allowed methods', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/users/:id' } as any
ctx.params = { id: 12453 }
ctx.request.request.method = 'PUT'
})
const csrf = csrfFactory({ enabled: true, methods: ['POST', 'PATCH', 'DELETE'] }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
assert.isDefined(ctx.request.csrfToken)
})
test('enforce validation request method is part of allowed methods', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/users/:id' } as any
ctx.params = { id: 12453 }
ctx.request.request.method = 'PATCH'
})
const csrf = csrfFactory({ enabled: true, methods: ['POST', 'PATCH', 'DELETE'] }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('skip validation when request route is ignored', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/users/:id' } as any
ctx.params = { id: 12453 }
ctx.request.request.method = 'PATCH'
})
const csrf = csrfFactory({ enabled: true, exceptRoutes: ['/users/:id'] }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
assert.isDefined(ctx.request.csrfToken)
})
test('skip validation when request route is ignored using a callback', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/users/:id' } as any
ctx.params = { id: 12453 }
ctx.request.request.method = 'PATCH'
})
const csrf = csrfFactory({ enabled: true, exceptRoutes: () => true }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
assert.isDefined(ctx.request.csrfToken)
})
test('validate when request route is not ignored', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, () => {
ctx.route = { pattern: '/users/:id' } as any
ctx.params = { id: 12453 }
ctx.request.request.method = 'PATCH'
})
const csrf = csrfFactory({ enabled: true, exceptRoutes: ['posts/:post/store'] }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('work fine when csrf token is provided as an input', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
ctx.session.put('csrf-secret', secret)
const csrfToken = tokens.create(secret)
ctx.request.updateBody({ _csrf: csrfToken })
})
const csrf = csrfFactory({ enabled: true }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
})
test('work fine when csrf token is provided as a header', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
ctx.session.put('csrf-secret', secret)
const csrfToken = tokens.create(secret)
ctx.request.request.headers = {
'x-csrf-token': csrfToken,
}
})
const csrf = csrfFactory({ enabled: true }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
})
test('work fine when csrf token is provided as an encrypted token', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
ctx.session.put('csrf-secret', secret)
const csrfToken = tokens.create(secret)
ctx.request.request.headers = {
'x-xsrf-token': `e:${encrpytion.encrypt(csrfToken, undefined, 'XSRF-TOKEN')!}`,
}
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: true }, encrpytion)
await assert.doesNotRejects(() => csrf(ctx))
})
test('fail when csrf input value is incorrect', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
ctx.request.updateBody({ _csrf: 'foo' })
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: true }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('fail when csrf header value is incorrect', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
ctx.request.request.headers = {
'x-csrf-token': 'foo',
}
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: true }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('fail when csrf encrypted header value is incorrect', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
ctx.request.request.headers = {
'x-xsrf-token': 'hello world',
}
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: true }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('fail when csrf encrypted header is valid but cookie feature is disabled', async ({
assert,
}) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
ctx.session.put('csrf-secret', secret)
const csrfToken = tokens.create(secret)
ctx.request.request.headers = {
'x-xsrf-token': `e:${encrpytion.encrypt(csrfToken, undefined, 'XSRF-TOKEN')!}`,
}
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: false }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('fail when csrf secret session is missing', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
const csrfToken = tokens.create(secret)
ctx.request.updateBody({ _csrf: csrfToken })
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: false }, encrpytion)
await assert.rejects(async () => csrf(ctx), new E_BAD_CSRF_TOKEN().message)
})
test('share CSRF token with templates and request', async ({ assert }) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
const secret = await tokens.secret()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'GET'
ctx.session.put('csrf-secret', secret)
})
const csrf = csrfFactory({ enabled: true, exceptRoutes: ['/'] }, encrpytion, Edge.create())
await csrf(ctx)
assert.isDefined(ctx.request.csrfToken)
assert.isTrue(tokens.verify(secret, ctx.request.csrfToken))
assert.equal(await ctx.view.renderRaw('{{ csrfToken }}'), ctx.request.csrfToken)
assert.equal(
await ctx.view.renderRaw('{{ csrfMeta() }}'),
`<meta name='csrf-token' content='${ctx.request.csrfToken}'>`
)
assert.equal(
await ctx.view.renderRaw('{{ csrfField() }}'),
`<input type='hidden' name='_csrf' value='${ctx.request.csrfToken}'>`
)
})
test('generate csrf token and share as a cookie when enableXsrfCookie is true', async ({
assert,
}) => {
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
const secret = await tokens.secret()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'GET'
ctx.session.put('csrf-secret', secret)
})
const csrf = csrfFactory(
{ enabled: true, enableXsrfCookie: true, exceptRoutes: ['/'] },
encrpytion,
Edge.create()
)
await csrf(ctx)
const cookieHeader = String(ctx.response.getHeader('set-cookie'))
const cookie = decodeURIComponent(cookieHeader).match(/XSRF-TOKEN=e:[^;]+/)![0]
assert.equal(
encrpytion.decrypt(cookie.replace('XSRF-TOKEN=e:', ''), 'XSRF-TOKEN'),
ctx.request.csrfToken
)
})
test('flash CSRF error message via flash messages', async ({ assert }) => {
assert.plan(1)
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
const secret = await tokens.secret()
const csrfToken = tokens.create(secret)
ctx.request.updateBody({ _csrf: csrfToken })
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: false }, encrpytion)
try {
await csrf(ctx)
} catch (error) {
await error.handle(error, ctx)
assert.deepEqual(ctx.session.responseFlashMessages.all(), {
errorsBag: {
E_BAD_CSRF_TOKEN: 'Invalid or expired CSRF token',
},
input: {},
})
}
})
test('get error message from i18n', async ({ assert }) => {
assert.plan(1)
const app = await setup()
const ctx = new HttpContextFactory().create()
const encrpytion = await app.container.make('encryption')
const middleware = await new SessionMiddlewareFactory().create()
const i18nManager = new I18nManagerFactory()
.merge({
config: {
loaders: [
() => {
return {
async load() {
return {
en: {
'errors.E_BAD_CSRF_TOKEN': 'Session expired',
},
}
},
}
},
],
},
})
.create()
await middleware.handle(ctx, async () => {
ctx.route = { pattern: '/' } as any
ctx.request.request.method = 'PATCH'
await i18nManager.loadTranslations()
ctx.i18n = i18nManager.locale('en')
const secret = await tokens.secret()
const csrfToken = tokens.create(secret)
ctx.request.updateBody({ _csrf: csrfToken })
})
const csrf = csrfFactory({ enabled: true, enableXsrfCookie: false }, encrpytion)
try {
await csrf(ctx)
} catch (error) {
await error.handle(error, ctx)
assert.deepEqual(ctx.session.responseFlashMessages.all(), {
errorsBag: {
E_BAD_CSRF_TOKEN: 'Session expired',
},
input: {},
})
}
})
})