Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installing electron deps with PNPM doesn't work #1598

Open
evoactivity opened this issue Sep 21, 2023 · 4 comments
Open

Installing electron deps with PNPM doesn't work #1598

evoactivity opened this issue Sep 21, 2023 · 4 comments

Comments

@evoactivity
Copy link
Contributor

I use PNPM for my monorepo. I have to use yarn to install the electron deps otherwise the project doesn't build.
@RobbieTheWagner
Copy link
Member

@evoactivity I am using pnpm and it works fine with https://github.com/shipshapecode/swach. Do you have steps to reproduce?

@evoactivity
Copy link
Contributor Author

Not on that project at the moment, will be in the next week or two. I'll try to recreate a reproduction repo for you.

@RobbieTheWagner
Copy link
Member

@evoactivity I think this is an Electron issue, not specific to ember-electron. I encountered the issue myself trying to build a new version. Something with symlinks and pnpm moving node_modules around messes with Electron and asar etc.

@bendemboski
Copy link
Member

Correct -- electron/forge#2633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@evoactivity @bendemboski @RobbieTheWagner