Source maps not loading with Electron 7.x #442
Comments
|
I was wondering what happened (thought maybe it was a problem on my side) |
2 tasks
bendemboski
added a commit
that referenced
this issue
May 18, 2020
`electron-protocol-serve` seems to have taken us too far off the beaten path, so this changes `ember-electron` to set up projects to load from file: URLs instead of the custom protocol. This requires a couple of workarounds to make Ember apps work properly when loaded from file: URLs -- all explained in detail in the new FAQ page. This gets us sourcemaps back in Electron 7+, and also removes the need for a variety of minor workarounds for security/sandboxing issues caused by our use of a custom protocol. Fixes #442
bendemboski
added a commit
that referenced
this issue
May 18, 2020
`electron-protocol-serve` seems to have taken us too far off the beaten path, so this changes `ember-electron` to set up projects to load from file: URLs instead of the custom protocol. This requires a couple of workarounds to make Ember apps work properly when loaded from file: URLs -- all explained in detail in the new FAQ page. This gets us sourcemaps back in Electron 7+, and also removes the need for a variety of minor workarounds for security/sandboxing issues caused by our use of a custom protocol. Fixes #442
bendemboski
added a commit
that referenced
this issue
May 18, 2020
`electron-protocol-serve` seems to have taken us too far off the beaten path, so this changes `ember-electron` to set up projects to load from file: URLs instead of the custom protocol. This requires a couple of workarounds to make Ember apps work properly when loaded from file: URLs -- all explained in detail in the new FAQ page. This gets us sourcemaps back in Electron 7+, and also removes the need for a variety of minor workarounds for security/sandboxing issues caused by our use of a custom protocol. Fixes #442
bendemboski
added a commit
that referenced
this issue
May 21, 2020
`electron-protocol-serve` seems to have taken us too far off the beaten path, so this changes `ember-electron` to set up projects to load from file: URLs instead of the custom protocol. This requires a couple of workarounds to make Ember apps work properly when loaded from file: URLs -- all explained in detail in the new FAQ page. This gets us sourcemaps back in Electron 7+, and also removes the need for a variety of minor workarounds for security/sandboxing issues caused by our use of a custom protocol. Fixes #442
bendemboski
added a commit
that referenced
this issue
May 21, 2020
`electron-protocol-serve` seems to have taken us too far off the beaten path, so this changes `ember-electron` to set up projects to load from file: URLs instead of the custom protocol. This requires a couple of workarounds to make Ember apps work properly when loaded from file: URLs -- all explained in detail in the new FAQ page. This gets us sourcemaps back in Electron 7+, and also removes the need for a variety of minor workarounds for security/sandboxing issues caused by our use of a custom protocol. Fixes #442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
ember electronwith Electron 7.x, if you open the dev tools, the source maps do not load.The root cause is changes in Chromium around the network service. Things broke in Electron 7.0.0, and this fix (a backport of this chromium fix) got source maps working again for
file:URLs. But they still don't work for custom protocols, like ourserve:protocol that we use withelectron-protocol-serve.Here is the Electron issue I filed tracking this, but I have no idea if it will get attention/a fix anytime soon. Possible alternatives:
sourceMappingURLdirective at the end of js files to use absolutefile:URLs to point to the source maps (instead of relative URLs that end up resolving to custom protocolserve:URLs)electron-protocol-servething, and go back to usingfile:URLs (which probably requires using the hash location type in Ember)The text was updated successfully, but these errors were encountered: