Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change: Do not perform two-way data binding by default #212

Open
alexlafroscia opened this issue Dec 20, 2018 · 0 comments
Open

Comments

@alexlafroscia
Copy link
Member

alexlafroscia commented Dec 20, 2018

Two-way data binding is an anti-pattern in Ember applications these days, and should be avoided where possible.

Currently, ember-pikaday performs two-day data binding to the value property by default. This behavior would be removed in favor of one-day data binding and better documentation of how to use the mut helper to explicitly bind to changes using onSelection

<PikedayInput
  @value={{value}}
  @onSelection={{action (mut value)}}
/>
@alexlafroscia alexlafroscia added this to the 3.0.0 milestone Dec 20, 2018
@ghost ghost pinned this issue Jun 27, 2019
@ghost ghost added the good first issue label Jul 8, 2019
@Turbo87 Turbo87 unpinned this issue Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants