Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all versions returned in available_releases have a corresponding binary #922

Open
Linloir opened this issue Feb 20, 2024 · 5 comments
Open
Labels
bug Something isn't working

Comments

@Linloir
Copy link

Linloir commented Feb 20, 2024

Describe the bug
For aarch64+mac (mac m2 devices), there is no release of feature version 8, which results in an inconsistency between the binary api and the available_releases api

screenshot_2024-02-20 21 09 29 截屏2024-02-20 21 10 15

Maybe add some filters to the available_releases api?

To Reproduce
Steps to reproduce the behavior:

  1. Fetch the available releases from the available_releases api
  2. Use the version 8 returned to construct a new request for binary
  3. Make the request
  4. Get the 404 error

Expected behavior
Either build the version or add filters to the available releases api

Device (please complete the following information):

  • OS: MacOS
@Linloir Linloir added the bug Something isn't working label Feb 20, 2024
@usmanovbf
Copy link

The same issue. Please, fix that

@karianna
Copy link
Contributor

IIRC - There is no Java 8 binary for Mac OS X (Silicon) that we release, so this is a bug in our API filtering.

@tellison
Copy link
Contributor

IIRC - There is no Java 8 binary for Mac OS X (Silicon) that we release, so this is a bug in our API filtering.

It is not a bug, the available_releases accurately returns the union of all release feature versions, with lts, most recent, and tip info. It doesn't take any parameters to specify the platform, or return any platform information - so you cannot assume all releases are available on all platforms (they are not).

Platform specific release information can be retrieved from, for example, the release_names request, e.g. for architecture=aarch64 and os=mac you can find the names for GA releases of a JDK via

curl -X 'GET' 'https://api.adoptium.net/v3/info/release_names?architecture=aarch64&os=mac&image_type=jdk&release_type=ga'

@johnoliver
Copy link
Contributor

johnoliver commented Apr 22, 2024

Calculating this page for an arbitrary set of user supplied filters would be potentially a comparatively expensive operation, and I am not sure if it offers a significant increase in functionality that other endpoints don't already make available, such as the /v3/info/release_names, /v3/info/release_versions or /v3/assets/feature_releases which can be used to determine if a version is available for a specific feature version.

@karianna
Copy link
Contributor

Calculating this page for an arbitrary set of user supplied filters would be potentially a comparatively expensive operation, and I am not sure if it offers a significant increase in functionality that other endpoints don't already make available, such as the /v3/info/release_names, /v3/info/release_versions or /v3/assets/feature_releases which can be used to determine if a version is available for a specific feature version.

An update to our API docs then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants