Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving from 3.4.0 to 3.4.1 breaks snapshots #150

Closed
tomatau opened this issue Oct 3, 2019 · 3 comments
Closed

moving from 3.4.0 to 3.4.1 breaks snapshots #150

tomatau opened this issue Oct 3, 2019 · 3 comments

Comments

@tomatau
Copy link

tomatau commented Oct 3, 2019

Output of a snapshot from a connected custom component in 3.4.0:

<Connect(CustomComponent) />

The output of a snapshot from the same connected custom component in 3.4.1:

<React.Memo />

A patch update shouldn't have this sort of breaking change. The utility of 3.4.0 is better than 3.4.1 as well as it conveys more information about the component.

@VincentLanglet
Copy link
Collaborator

Need to revert #145

@VincentLanglet
Copy link
Collaborator

I did it in release 3.4.2

The PR was made to fix this issue.
#137

<React.Memo /> instead of <Connect(CustomComponent) /> is not great indeed.

I'd like to have <React.Memo(CustomComponent) />

@tomatau
Copy link
Author

tomatau commented Oct 3, 2019

Thanks, 3.4.2 is back to non-breaking changes.

@tomatau tomatau closed this as completed Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants