Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for shader includes #104

Open
adriengivry opened this issue Jun 12, 2020 · 2 comments · May be fixed by #269
Open

Support for shader includes #104

adriengivry opened this issue Jun 12, 2020 · 2 comments · May be fixed by #269
Labels
Feature New feature to the engine Graphics Graphical feature

Comments

@adriengivry
Copy link
Owner

Problem this feature should fix
Some shaders are implementing the same functions instead of sharing them.

Expected solution
It could be nice to have to possibility to include some "Shader function file" into our shaders. We can imagine a standard #include ... directive that can be parsed by our shader loader and replaced by the content of the file to include.
@adriengivry adriengivry added Feature New feature to the engine Graphics Graphical feature labels Jun 12, 2020
@demurzasty
Copy link
Contributor

How about this: https://github.com/nothings/stb/blob/master/stb_include.h? 🙂

@adriengivry
Copy link
Owner Author

@demurzasty Could do the trick! I've actually started to work a bit on this, I have a branch for it:
https://github.com/adriengivry/Overload/tree/feature/shader_preprocessor

Only WIP stuff, I've moved to OvRendering future-proof refactoring

@adriengivry adriengivry mentioned this issue Nov 24, 2021
Closed
@adriengivry adriengivry linked a pull request Nov 23, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New feature to the engine Graphics Graphical feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding support for shader includes pre-processor directives adriengivry/Overload
2 participants
@demurzasty @adriengivry