Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of RAII idiom for the WidgetContainer class #281

Open
maxbrundev opened this issue Dec 7, 2023 · 0 comments
Open

Use of RAII idiom for the WidgetContainer class #281

maxbrundev opened this issue Dec 7, 2023 · 0 comments
Assignees
@maxbrundev
Labels
Bug Something isn't working

Comments

@maxbrundev
Copy link
Collaborator

maxbrundev commented Dec 7, 2023 •
edited

Description
Currently the WidgetContainer class use raw pointers and users has to de-allocate memory manually.

Expected behavior
We should replace the usage of raw pointers by unique_ptr and be able to transfer the ownership of an allocated Widget to an another WidgetContainer.
The EMemoryMode should be also removed since there is no use case of concrete shared ownership of Widgets
@maxbrundev maxbrundev added the Bug Something isn't working label Dec 7, 2023
@maxbrundev maxbrundev self-assigned this Dec 7, 2023
This was referenced Dec 7, 2023
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxbrundev maxbrundev

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxbrundev