Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove serialization unnecessary p_doc parameter #282

Open
adriengivry opened this issue Dec 7, 2023 · 0 comments
Open

Remove serialization unnecessary p_doc parameter #282

adriengivry opened this issue Dec 7, 2023 · 0 comments
Labels
Cleanup Code cleanup Good First Issue An easy issue for new contributors Refactoring Something that needs a refactoring

Comments

@adriengivry
Copy link
Owner

Problem this feature should fix
ISerializable::OnDeserialize never make use of the tinyxml2::XMLDocument& p_doc
Same for helpers: OvCore::Helpers::Serializer::Deserialize[...].

Expected solution
We should consider getting rid of it these tinyxml2::XMLDocument& p_doc references in deserialization functions.
@adriengivry adriengivry added Refactoring Something that needs a refactoring Cleanup Code cleanup Good First Issue An easy issue for new contributors labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup Code cleanup Good First Issue An easy issue for new contributors Refactoring Something that needs a refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriengivry