Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Asset Browser rework #286

Open
adriengivry opened this issue Dec 8, 2023 · 0 comments
Open

Asset Browser rework #286

adriengivry opened this issue Dec 8, 2023 · 0 comments
Labels
Cleanup Code cleanup

Comments

@adriengivry
Copy link
Owner

Problem this feature should fix
The asset browser panel code is currently a ginormous mess.

Expected solution
We should look into refactoring it, including:

  • More reusable code, split into proper functions (external files?)
  • Avoid magic numbers and undocumented constants (i.e., some xml code is spread into the file)
  • Define/include constants from other files, we shouldn't have to redefine file types, extensions, etc...
  • Avoid #define for constants, use constexpr instead.
@adriengivry adriengivry added the Cleanup Code cleanup label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup Code cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriengivry