Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OvMaths::Internal::TransformNotifier shouldn't be referred to in any .h file #291

Open
adriengivry opened this issue Dec 10, 2023 · 0 comments
Open

OvMaths::Internal::TransformNotifier shouldn't be referred to in any .h file #291

adriengivry opened this issue Dec 10, 2023 · 0 comments
Labels
Refactoring Something that needs a refactoring

Comments

@adriengivry
Copy link
Owner

User problem
TransformNotifier being an internal component of the FTransform implementation, it shouldn't be publicly exposed/visible to any other part of the engine. Currently, including FTransform will result into TransformNotifier being publicly exposed.

Expected solution
Move TransformNotifier from FTransform.h to FTransform.cpp (add a private forward declaration to the FTransform class declaration).
@adriengivry adriengivry added the Refactoring Something that needs a refactoring label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Refactoring Something that needs a refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adriengivry