Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate dropping OvUI to follow the IMGUI paradigm #293

Open
adriengivry opened this issue Dec 11, 2023 · 1 comment
Open

Investigate dropping OvUI to follow the IMGUI paradigm #293

adriengivry opened this issue Dec 11, 2023 · 1 comment
Labels
Documentation Improvements or additions to documentation Editor Something relative with the editor Refactoring Something that needs a refactoring

Comments

@adriengivry
Copy link
Owner

adriengivry commented Dec 11, 2023

Problem this feature should fix
While OvUI works fairly well, it adds an abstraction layer that it often not necessary, and require to write more complex code than if the underlying ImGUI library was used directly.

Expected solution
We should look into the IMGUI paradigm, and evaluate whether we should move away from OvUI to using ImGUI directly in OvEditor.

https://github.com/ocornut/imgui/wiki/About-the-IMGUI-paradigm

@adriengivry adriengivry added Feature New feature to the engine Editor Something relative with the editor Refactoring Something that needs a refactoring Documentation Improvements or additions to documentation and removed Feature New feature to the engine labels Dec 11, 2023
@maxbrundev
Copy link
Collaborator

maxbrundev commented Dec 11, 2023

Definitely, in my opinion the encapsulation is great especially widgets side but the architecture is adding an unnecessary layer of complexity and it's too much event based to update the widgets data.

However the usage of imgui directly into the editor would not be the best choice as it will add some noise especially if later we want to allow users to create custom GUI, I am not sure that it will be cleaner to remove OvUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation Editor Something relative with the editor Refactoring Something that needs a refactoring
Projects
None yet
Development

No branches or pull requests

2 participants