Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image replacement not displayed in review Link #204

Open
ravindra-dange opened this issue Nov 8, 2021 · 11 comments
Open

Image replacement not displayed in review Link #204

ravindra-dange opened this issue Nov 8, 2021 · 11 comments
Labels
bug Something isn't working

Comments

@ravindra-dange
Copy link

Replace image in CMS with same name without Publishing in Draft mode, and create View/Edit link, the updated images are not displayed in View link.
@barteksekula
Copy link
Member

@ravindra-dange please send more details. how do you render the images, do you use htmlhelper? how does the display template for img look like?

@barteksekula barteksekula added the question Further information is requested label Nov 16, 2021
@ravindra-dange
Copy link
Author

ravindra-dange commented Nov 17, 2021 via email

@barteksekula
Copy link
Member

Did you upload the screenshots?
I can see your comment like this:
image

@ravindra-dange
Copy link
Author

Hello Bartosz,

We have added images in XHTMLString. And we render Content from XHTMLString on Page.
I see images getting Rendered in externalContentView Page in below Format.

image

If the version of image is added in contentLink ID while rendering the image I can see Draft image replaced:
image (1)

Can you please help me in getting rendered Draft verion of image associated with respective image.

Below is View file to render the HTML block:

image (2)

Thanks,
Ravindra

@ravindra-dange
Copy link
Author

@barteksekula
Hello Bartosz,

I verified same issue in Alloy site by replacing the image and was able to replicate the issue:
Following image was replaced with Black Background:
image

In externalContentView Link I see Old image instead of replaced image:
image

Expected Output should be below(Edited ContentLID manually):
image

Thanks,
Ravindra

@barteksekula barteksekula added bug Something isn't working and removed question Further information is requested labels Nov 18, 2021
@barteksekula
Copy link
Member

Thank you. I will investigate.

@barteksekula
Copy link
Member

Sorry it took so long. I am still not able to reproduce this:
image
The image always has the full ID contentLink_workId
I was not able to reproduce a scenario when there would just be the contentLink without the workID

@ravindra-dange
Copy link
Author

@barteksekula
Hello Bartosz,

Below are steps to reproduce issue:

  1. Create Project in Episerver and select the Project before Editing.

  2. Create image with Same name which needs to be replaced

  3. Go to Block where image needs to be replaced
    image

  4. Select new image to be replaced having same name:
    image

  5. Click Replace File:
    image

  6. In Edit mode, new image will be displayed:
    image

  7. In Project the image will appear in Draft mode:
    image

  8. Create Draft Review Link:
    image

  9. The review link will not show Draft image instead will display Old image:
    image

Thanks,
Ravindra

@barteksekula
Copy link
Member

Oh, you never mentioned you're in project mode before.

@barteksekula barteksekula added this to the 1.2.0 milestone May 4, 2022
@barteksekula barteksekula removed this from the 1.2.0 milestone Sep 21, 2022
@daniel-isaacs
Copy link

Unless I'm mistaken, isn't step 5 is going to replace the image in the system (and, using default setup, automatically publish the new version of that image file)? So, the external review page might be showing a cached version of that file (do you have Cloudflare set up, for example?). But in reality, I think the new image might already be in-use on the published version of the site.

I think the more expected scenario is: upload the new image file with a different filename than the existing image. Then, in that block/page property, replace the old image with that newly uploaded image. This way, the external View link should show the new image, but the published page will still use the old image.

@ravindra-dange
Copy link
Author

ravindra-dange commented Oct 11, 2022 via email

@barteksekula barteksekula added this to the 1.2.2 milestone Oct 25, 2022
@barteksekula barteksekula modified the milestones: 1.2.2, 1.3.2 Nov 28, 2022
@barteksekula barteksekula removed this from the 1.3.2 milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@barteksekula @daniel-isaacs @ravindra-dange