Skip to content
This repository has been archived by the owner on Jun 18, 2021. It is now read-only.

Simplify/unify generic code (CommandNames, GBounded, Rank2) #260

Open
stevana opened this issue Jan 7, 2019 · 1 comment
Open

Simplify/unify generic code (CommandNames, GBounded, Rank2) #260

stevana opened this issue Jan 7, 2019 · 1 comment

Comments

@stevana
Copy link
Collaborator

stevana commented Jan 7, 2019

In PR #259 it was noted that GConName/CommandNames could be simplified using generic-sop. In PR #242 another dependency on generic-data is introduced in order to get generic bounded and enum instances. Perhaps generic-sop or generic-data can be used for both, and also the Rank2 stuff.

We should consider how much the refactor would simplify the library (if at all considering the overhead of, for example, learning generic-sop) vs how annoying it would be for the users of the library (yet another dependency, api change, extension and deriving instance, etc)...

@Lysxia
Copy link
Collaborator

Lysxia commented Jan 7, 2019

I also put gconName in generic-data. The plural version gconNames can be obtained as map conIdToString (conIdEnum @MyType); I wouldn't mind adding it as a shorthand too.

I'm not sure what to do about Rank2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants