-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement booleans #56
Comments
Oh, thanks for the note @s-ol, think I've overlooked this one when merging #48. @davidgranstrom, maybe you have an idea what is missing? |
@s-ol @adzialocha I think that adding corresponding values for the It was a while since I wrote the PR so I would have to take a closer look to see what is actually needed. But I think it is mainly about adding the values in |
Thank you @davidgranstrom ! I had a go on an implementation here, please have a look if you have time: #59 |
@adzialocha That was fast :) Looks good to me! 👍 |
Super, lets release it then! |
The boolean type tags are listed in the wiki but don't actually work:
TypedMessage.pack
doesn't implement themTypedMessage.unpack
implements them wrongly (will end the message if it encounters a boolean)typeTag
doesn't implement them, meaningMessage.add
can't use themAlso, while in the OSC protocol booleans take no space in the message encoding, I think it would be beneficial to add
true
/false
values intoTypedMessage.args
at the corresponding position. Otherwise the mapping fromtype
toargs
is broken, which means the user has to essentially re-parse the type string just to find the corresponding value.The text was updated successfully, but these errors were encountered: