Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert Link modal buttons get hidden behind by keyboard #1266

Open
nightgolfer opened this issue Feb 28, 2024 · 0 comments
Open

Insert Link modal buttons get hidden behind by keyboard #1266

nightgolfer opened this issue Feb 28, 2024 · 0 comments
Labels
bug Something isn't working platform:pwa

Comments

@nightgolfer
Copy link

nightgolfer commented Feb 28, 2024

Describe the bug

[While composing a comment or new post] When selecting one or more words and clicking the Insert Link button, the Insert Link modal appears.

When either of the modal's two input fields is clicked, the OK and Cancel buttons get hidden behind the keyboard. This might be because my Gboard adds an extra line with Password / Credit Card/ Address shortcuts when a text field is explicitly selected (they're not there when the modal initially appears, even though the URL field has focus).

The "replying-to"-excerpt and formatting bar correctly shift upwards when the new row of keyboard icons appears, but the Insert Link modal doesn't budge, remaining centered on the screen, resulting in the OK / Cancel buttons disappearing behind the new bar.

To gain access to the buttons again, I either need to dismiss the keyboard (swipe Back), or click the modal title (Insert Link), effectively dismissing the keyboard as well.

Note: The initial state is usually that the two buttons are visible when the modal first appears, but sometimes the extra keyboard line is already present, thus hiding the buttons instantly. I think this is because Gboard can remember the explicit input field selection between modal "sessions", and maybe the modal only gets hidden when exited.

To Reproduce

Reproducibility probably requires a similar combination of keyboard, keyboard settings, screen size and screen resolution (or UI scaling) to mine (Android, Gboard, OnePlus Nord), or at least a really tall keyboard.

  1. While composing a comment, select a word and press the Insert Link button.

  2. The Insert Link modal appears. The OK and Cancel buttons should be visible.

  3. Click on either modal input field (Description or URL). The buttons disappear behind the Gboard shortcuts bar.

  4. Go Back or click the modal title (exit input field without dismissing modal) to dismiss the keyboard.

  5. Modal buttons are now visible again.

Expected behavior

Modals should always be placed relative to available screen size minus current keyboard height, instead of just centered in the middle of the screen. Make sure modals react to keyboard size, and keyboard size changes.

Screenshots
Screenshot_2024-02-28-09-28-26-43_40deb401b9ffe8e1df2f1cc5ba480b12~3.jpg

Screenshot_2024-02-28-09-29-31-26_40deb401b9ffe8e1df2f1cc5ba480b12~3.jpg

Screenshot_2024-02-28-09-29-43-69_40deb401b9ffe8e1df2f1cc5ba480b12~2.jpg

Screenshot_2024-02-28-09-29-55-90_40deb401b9ffe8e1df2f1cc5ba480b12~2.jpg

Desktop (please complete the following information):

N/A

Smartphone (please complete the following information):

  • Device: OnePlus Nord
  • OS: Android
  • Browser: PWA
  • Version [1.42.0]

*Additional context

N/A

@nightgolfer nightgolfer added the bug Something isn't working label Feb 28, 2024
@nightgolfer nightgolfer changed the title [Bug] PWA: Insert Link modal OK/CANCEL buttons get blocked by keyboard [Bug] PWA: Insert Link modal OK/CANCEL buttons get blocked / hidden behind by keyboard Feb 28, 2024
@nightgolfer nightgolfer changed the title [Bug] PWA: Insert Link modal OK/CANCEL buttons get blocked / hidden behind by keyboard [Bug] PWA: Insert Link modal OK/CANCEL buttons get hidden behind by keyboard Feb 28, 2024
@aeharding aeharding changed the title [Bug] PWA: Insert Link modal OK/CANCEL buttons get hidden behind by keyboard Insert Link modal OK/CANCEL buttons get hidden behind by keyboard Mar 2, 2024
@aeharding aeharding changed the title Insert Link modal OK/CANCEL buttons get hidden behind by keyboard Insert Link modal buttons get hidden behind by keyboard Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working platform:pwa
Projects
None yet
Development

No branches or pull requests

2 participants