Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of code in the library #1017

Open
1 task
jpoiret opened this issue Jun 28, 2023 · 3 comments
Open
1 task

Duplication of code in the library #1017

jpoiret opened this issue Jun 28, 2023 · 3 comments

Comments

@jpoiret
Copy link
Contributor

jpoiret commented Jun 28, 2023

I've been noticing quite a lot of code that's duplicated in the library recently, so I think we could create a main issue for all such cases that we can expand over time. I haven't been taking notes up to now, so I'll add stuff as I stumble upon it. If you see any duplicated code, please mention it here and I'll add it to the list.

  • cong-∙ and congFunct with their related functions in Cubical.Foundations.GroupoidLaws.
@phijor
Copy link
Contributor

phijor commented Oct 21, 2023

uaη is proved twice:

The latter is a much more direct proof.

@mortberg
Copy link
Collaborator

Feel free to make PRs either removing one of the proofs or documenting why we have two versions (maybe also moving results to the same place).

Something that annoyed me recently is that we have both Data.Fin and Data.FinData. Some things are done with one version of Fin and some with the other. It would be better to get decide which version to use and get rid of the other. I think I prefer Data.Fin instead of Data.FinData

@phijor
Copy link
Contributor

phijor commented Feb 20, 2024

Another day, another duplication. Cubical.HITs.Settruncation.Properties contains two proofs of Iso ∥ Σ A B ∥₂ ∥ Σ A (λ x → ∥ B x ∥₂) ∥₂:

Up to η-expansion of Iso , these are definitionally the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants