Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New rule: comment added within X hours of worklog #40

Open
dspasojevic opened this issue May 13, 2021 · 0 comments
Open

New rule: comment added within X hours of worklog #40

dspasojevic opened this issue May 13, 2021 · 0 comments

Comments

@dspasojevic
Copy link
Member

Our current comment checking rule requires a comment if:

  1. time has been logged AND the issue isn't closed
  2. OR the issue is in progress

A conceptually simpler rule is to require a comment whenever time has been logged. i.e a comment must be added "around" the same time that a worklog is added.

The check would look at:

  1. time of most recent worklog
  2. time of most recent comment

the rule would pass if the comment was <1d before the worklog or after it.

What makes it non-trivial is that worklogs and comments are both paginated fields, so they may be truncated. Issues are currently retrieved using the search API. We need to do one of:

  1. see if those fields can be sorted so that we always get the most recent comment and worklog
  2. check search results and (if necessary) pull individual ticket comments and worklogs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant