Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: support full URLs #8

Open
seasonedfish opened this issue Nov 9, 2021 · 8 comments
Open

feature request: support full URLs #8

seasonedfish opened this issue Nov 9, 2021 · 8 comments
Assignees

Comments

@seasonedfish
Copy link

I prefer copying the full URL of a repository, e.g. https://github.com/Tarrasch/zsh-bd, over the path, e.g. Tarrasch/zsh-bd.

However, I get an error when I use the full URL with zcomet:
Screen Shot 2021-11-08 at 6 36 03 PM

I'm guessing zcomet automatically adds https://github.com/ to the argument of load.

It would be more convenient if zcomet supported full URLs. Another benefit would be support for repositories outside of Github

@agkozak
Copy link
Owner

agkozak commented Nov 9, 2021

Thanks for showing interest!

What you say is absolutely true, and the features you're asking for are definitely part of the plan. I'll let you know when I add them.

@agkozak agkozak self-assigned this Nov 9, 2021
@seasonedfish
Copy link
Author

Ah cool, thanks!

@agkozak
Copy link
Owner

agkozak commented Nov 12, 2021

It was quite easy to make zcomet accept full GitHub URLs, e.g.

https://github.com/agkozak/zsh-z
http://github.com/agkozak/zsh-z
https://github.com/agkozak/zsh-z.git
https://github.com/agkozak/zsh-z.git@some-branch

I've got the changes up on the github branch. I'd love it if you have the time to try it out; if you're happy with how it works, I'll merge it to master.

After that I'll tackle non-GitHub URLs, protocols other than HTTP(S), etc. etc.

@seasonedfish
Copy link
Author

Thanks so much! It works well.

@agkozak
Copy link
Owner

agkozak commented Nov 16, 2021

Great. I merged it to master. Non-GitHub Git servers are next. I'll keep you informed.

@megalithic
Copy link

@agkozak Could we close this issue if it's all merged it? Thanks!

@agkozak
Copy link
Owner

agkozak commented Dec 23, 2021

I haven't addressed non-GitHub servers yet, so I'd prefer to keep it open, if that's all right.

@megalithic
Copy link

I haven't addressed non-GitHub servers yet, so I'd prefer to keep it open, if that's all right.

absolutely! seemed like y'all got things fixed/working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants